https://github.com/MarketoMA/marketo_ma/pull/4

Starts PhantomJS and runs the tests.

Comments

Jaesin created an issue. See original summary.

Jaesin’s picture

Jaesin CreditAttribution: Jaesin at Chapter Three commented
Status: Active » Needs review
RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey at FFW commented

I have merged the pull request.

https://github.com/MarketoMA/marketo_ma/pull/4

I am leaving the status the same since I am not sure how to test this.

Jaesin’s picture

Jaesin CreditAttribution: Jaesin at Chapter Three commented

See https://travis-ci.org/MarketoMA/marketo_ma/builds/168831587

As you see the tests are running. The tests don't need to pass to satisfy this ticket.

RoloDMonkey’s picture

RoloDMonkey CreditAttribution: RoloDMonkey at FFW commented
Status: Needs review » Reviewed & tested by the community

I think I understand. Before, the tests were throwing an error. Now, they are merely failing :)

Jaesin’s picture

Jaesin CreditAttribution: Jaesin at Chapter Three commented

Exactly. https://www.drupal.org/node/2815369 didn't update any of the tests as far as I know.

  • jyokum committed c25be10 on 8.x-2.x 
    Issue #2812771 by Jaesin, jyokum: Travis build updated to execute both...
jyokum’s picture

jyokum CreditAttribution: jyokum commented
Status: Reviewed & tested by the community » Fixed

I've updated to use the same build as 7.x branch which is based on drupal_ti. Both Behat and phpunit tests are executing.

FYI. phpunit test can be manually run with the following:

cd <drupal_root>/core
../vendor/bin/phpunit ../modules/marketo_ma/tests/src

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.