Currently, the node revision overview page shows a constructed message indicating what parts of the node have changed. This is very useful. I would like to propose to additionally show the revision log message that the user entered, as it can give an indication of why it was changed.

In the screenshot attached I indicated what information and where to put it. Note that the information is already present on the actual diff page that compares two revisions. (screenshot partly anonymized, and partly translated to Dutch)

CommentFileSizeAuthor
revision-overview-show-log.png41.05 KBdhendriks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dhendriks created an issue. See original summary.

miro_dietiker’s picture

Issue tags: +Usability

Hm, the autogenerated message was supposed to be a fallback if no revision log was created by the user.

I tested and if the message is manually added by the user, it's properly displayed in the overview page.
Please recheck and update your request.

dhendriks’s picture

I already check that actually, as you can see from the screenshot. It shows the overview page of the revisions of a node, and a diff for the latest 2 revisions of that node. Both revisions have a log message, as indicated with the green circles. Those log messages are not displayed on the overview page.

Also, my suggestions is to always show the generated text about what is changed, and additionally indicate the user provided log message (if available), that gives an indication why it is changed.

johnchque’s picture

Status: Active » Postponed (maintainer needs more info)

We are working on making the autogenerated summary better in #2806119: Paragraph always changed in revision summary. But I couldn't reproduce what you point either, can you try creating another node and see if the summary is displayed then, can you check if it is in the markup somehow and hidden probably?

miro_dietiker’s picture

dhendriks’s picture

OK, so I tried it again, with diff-8.x-1.0-beta2. I used old nodes, and created a new test node. The node revision overview page doesn't every display a user entered log message, only auto-generated ones.

Here is the HTML of the revision overview page of a newly created test node. The test node has two revisions, both with a custom log message. The page uses the Dutch language. The domain and user names have been anonymized.

<TABLE class="diff-revisions responsive-enabled" id="edit-node-revisions-table" 
data-drupal-selector="edit-node-revisions-table" data-striping="1">
  <THEAD>
  <TR>
    <TH>Revisie</TH>
    <TH></TH>
    <TH></TH>
    <TH>Operations</TH></TR></THEAD>
  <TBODY>
  <TR class="odd" data-drupal-selector="edit-node-revisions-table-0">
    <TD><A href="http://example.com/kalender/test2" hreflang="nl">15-10-2016 - 
      15:07</A> door <A title="Gebruikersprofiel weergeven." class="username" 
      lang="" href="http://example.com/gebruiker/my-name" datatype="" 
      property="schema:name" typeof="schema:Person" about="/gebruiker/my-name">My 
      Name</A>
      <P class="revision-log">Changes on: Beschrijving</P></TD>
    <TD>
      <DIV class="js-form-item form-item js-form-type-radio form-type-radio js-form-item-radios-left form-item-radios-left form-no-label"><INPUT 
      name="radios_left" class="form-radio" id="edit-node-revisions-table-0-select-column-one" 
      type="radio" value="851" data-drupal-selector="edit-node-revisions-table-0-select-column-one"> 
              </DIV></TD>
    <TD>
      <DIV class="js-form-item form-item js-form-type-radio form-type-radio js-form-item-radios-right form-item-radios-right form-no-label"><INPUT 
      name="radios_right" class="form-radio" id="edit-node-revisions-table-0-select-column-two" 
      type="radio" value="851" data-drupal-selector="edit-node-revisions-table-0-select-column-two"> 
              </DIV></TD>
    <TD><EM>Huidige revisie</EM></TD></TR>
  <TR class="even" data-drupal-selector="edit-node-revisions-table-1">
    <TD><A href="http://example.com/node/412/revisions/850/view">15-10-2016 - 
      15:06</A> door <A title="Gebruikersprofiel weergeven." class="username" 
      lang="" href="http://example.com/gebruiker/my-name" datatype="" 
      property="schema:name" typeof="schema:Person" about="/gebruiker/my-name">My 
      Name</A>
      <P class="revision-log">Initial revision.</P></TD>
    <TD>
      <DIV class="js-form-item form-item js-form-type-radio form-type-radio js-form-item-radios-left form-item-radios-left form-no-label"><INPUT 
      name="radios_left" class="form-radio" id="edit-node-revisions-table-1-select-column-one" 
      type="radio" value="850" data-drupal-selector="edit-node-revisions-table-1-select-column-one"> 
              </DIV></TD>
    <TD>
      <DIV class="js-form-item form-item js-form-type-radio form-type-radio js-form-item-radios-right form-item-radios-right form-no-label"><INPUT 
      name="radios_right" class="form-radio" id="edit-node-revisions-table-1-select-column-two" 
      type="radio" value="850" data-drupal-selector="edit-node-revisions-table-1-select-column-two"> 
              </DIV></TD>
    <TD>
      <DIV class="dropbutton-wrapper">
      <DIV class="dropbutton-widget">
      <UL class="dropbutton" data-drupal-selector="edit-node-revisions-table-1-operations">
        <LI class="revert"><A href="http://example.com/node/412/revisions/850/revert">Terugzetten</A></LI>
        <LI class="delete"><A href="http://example.com/node/412/revisions/850/delete?langcode=nl">Verwijderen</A></LI></UL></DIV></DIV></TD></TR></TBODY></TABLE>
johnchque’s picture

Can you give us one example of your revision log that is not displayed please?

dhendriks’s picture

Can you give us one example of your revision log that is not displayed please?

The screenshot I attached when I reported the issue shows an example. It shows the revision overview and the actual diff of the last 2 revisions. The last one has log message 'Nieuwe bijlage' and the before-last one has log message 'Nieuwe zaalindeling'. They are shown at the actual diff (green circles), but the overview page shows only auto-generated messages.

Is this what you mean by an example, or did you have something else in mind?

johnchque’s picture

I would like to see the raw value. :)

dhendriks’s picture

I would like to see the raw value. :)

From the database? Or from the HTML? Could you be a bit more specific?

johnchque’s picture

I think that there are some strange chars in your log, database might be helpful and how is shown in the html too.

dhendriks’s picture

HTML for diff between 2 revisions (only table header, as that is where the revision log messages are):

      <thead>
      <tr>
                            <th colspan="3">Nieuwe zaalindeling<a href="http://[domain_anonymized]/node/153/revisions/670/view">3-9-2016 - 10:13</a></th>
                            <th colspan="3">nieuwe bijlage<a href="http://[domain_anonymized]/node/153/revisions/778/view">18-9-2016 - 21:55</a></th>
              </tr>
    </thead>

From the database, for revision 778, the log message is: "nieuwe bijlage". For revision 670 it is: "Nieuwe zaalindeling". I copied these directly from the phpMyAdmin, from the revision log cell. I don't see any special characters.

dhendriks’s picture

It seems this is now resolved:
- The log message for the diff is displayed, as requested for this issue.
- The 'Changes on' part that was presented before, is no longer presented.

I'm using diff-8.x-1.0.