The string comparison in email_confirm_user_presave is case sensitive, so if someone changes their email from Greg@example.com to greg@example.com then email confirm will send an email when it really shouldn't.

The code should probably do a drupal_strtolower() on each string prior to the comparison.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles created an issue. See original summary.

coltrane’s picture

Status: Active » Needs review
FileSize
1.05 KB

Here's a patch

greggles’s picture

Status: Needs review » Needs work

The last submitted patch, 3: 2811837-confirm-insensitive-with-tests-d7.patch, failed testing.

greggles’s picture

Status: Needs work » Needs review
FileSize
2.55 KB

Let's try that again.

Status: Needs review » Needs work

The last submitted patch, 5: 2811837-confirm-insensitive-with-tests-d7.patch, failed testing.

greggles’s picture

Status: Needs work » Needs review
FileSize
2.55 KB

patch -p1 could handle that last patch, but not git apply, so...here's a new one that works for me locally using "git apply".

  • greggles committed 3065e90 on 7.x-1.x authored by coltrane
    Issue #2811837 by greggles, coltrane: Email change should be case...
greggles’s picture

Status: Needs review » Fixed

OK, committed and pushed. Thanks, coltrane!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.