The latest version of panels (specifically PanelsIPELayoutForm class) calls LayoutBase::getLayout(). That method exists in HEAD of 8.x-1.x branch but:

No release has been made since that commit, and
There is no issue related to that commit so the patch doesn't exist anywhere for me to pull in (at least not that I can find)

So this issue is just a place to store that patch (which adds the getLayout method among other things) until layout_plugin can make another release.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

balsama created an issue. See original summary.

balsama’s picture

This patch represents the difference between commits eb01ded1970ba3751b3bf7023d4b9983f1db1494 and 96a5cf906097a307100ef85642e2a6f603296aa2 and should add the getLabel method among other things.

Setting needs review because I really don't know what else to set it as. I guess we can close this when alpha23 comes out? dsnopek, obviously feel free to do what you want with this issue - I really just need the patch hosted on D.O _somewhere_ :)

Status: Needs review » Needs work

The last submitted patch, 2: 2811423-2.patch, failed testing.

The last submitted patch, 2: 2811423-2.patch, failed testing.

balsama’s picture

Unsurprisingly, this patch doesn't apply to alpha22. I've created a "mega patch" that represents all the commits between alpha22 and 96a5cf90 which I'll host over in Lightnings "Mega Patch" issue instead: #2747739: Create and host "mega" patches until the Panels ecosystem stabilizes and releases.

dsnopek’s picture

Title: Add public getLayout() method to LayoutBase » Add public getLabel() method to LayoutBase

Hrm. If Panels is calling a method on LayoutBase that isn't on LayoutInterface then that is a bug in Panels, and I encourage you to open an issue there! Modules using layout_plugin should only call methods on the interface...

dsnopek’s picture

I should also note, that one of the possible outcomes of #2699841: Provide better API for getting information about layouts (without putting more methods on the interface) is to remove these public "info methods" from LayoutBase and move them to a plugin definition class of some kind (that's my preferred outcome for that issue). So, that's even more reason not to depend on them.