Advanced panels 8.x-3.x based on the work of Lightning profile [#2810533]

This is to have a patch file to put all Advanced panels 8.x-3.x based on the work of Lightning profile. to work with panels 8.x-3.0-beta5

#2747739: Create and host "mega" patches until the Panels ecosystem stabilizes and releases.

This patch if it got posted to panels will open work for other modules. like panlizer

Comment	File	Size	Author
#10	panels--8-x-3-0-beta5---2810533-10.patch	274.58 KB	Rajab Natshah
#10	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 28 pass PHP 5.6 & MySQL 5.5, D8.3 28 pass PHP 7 & MySQL 5.5, D8.3 28 pass
#5	panels--8-x-3-0-beta5---2810533-3.patch	265.11 KB	Rajab Natshah
#5	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.3 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.3 Patch failed to apply
#2	2810533-2.patch	41.94 KB	Rajab Natshah
#2	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 October 2016 at 14:36

RajabNatshah created an issue. See original summary.

Comment #2

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 14:37

File	Size
2810533-2.patch	41.94 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply

Comment #3

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 14:40

Assigned:	Rajab Natshah	» Unassigned
Status:	Needs work	» Needs review

Comment #4

3 October 2016 at 14:42

Status:

Needs review

» Needs work

The last submitted patch, 2: 2810533-2.patch, failed testing.

Comment #5

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 16:40

File	Size
panels--8-x-3-0-beta5---2810533-3.patch	265.11 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.3 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.3 Patch failed to apply

Patched with binary data.

Comment #6

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 16:41

1 file was hidden/shown/deleted

File	Size
2810533-2.patch	41.94 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply

Comment #7

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 16:49

Status:

Needs work

» Needs review

Comment #8

3 October 2016 at 16:51

Status:

Needs review

» Needs work

The last submitted patch, 5: panels--8-x-3-0-beta5---2810533-3.patch, failed testing.

Comment #9

3 October 2016 at 16:55

The last submitted patch, 5: panels--8-x-3-0-beta5---2810533-3.patch, failed testing.

Comment #10

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 17:16

File	Size
panels--8-x-3-0-beta5---2810533-10.patch	274.58 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 28 pass PHP 5.6 & MySQL 5.5, D8.3 28 pass PHP 7 & MySQL 5.5, D8.3 28 pass

1 file was hidden/shown/deleted

File	Size
panels--8-x-3-0-beta5---2810533-3.patch	265.11 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.3 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.3 Patch failed to apply PHP 7 & MySQL 5.5, D8.3 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.3 Patch failed to apply

Comment #11

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 17:16

Status:

Needs work

» Needs review

Comment #12

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha as a volunteer commented 3 October 2016 at 17:54

Status:

Needs review

» Needs work

+++ b/panels_ipe/src/Controller/PanelsIPEPageController.php
@@ -1,5 +1,10 @@
+/**
+ * @file
+ * Contains \Drupal\panels_ipe\Controller\PanelsIPEPageController.
+ */

Unneeded. Remove it

+++ b/panels_ipe/src/Form/PanelsIPEBlockContentForm.php
@@ -1,5 +1,10 @@
+/**
+ * @file
+ * Contains \Drupal\panels_ipe\Form\PanelsIPEBlockContentForm.
+ */

Unneeded. Remove it

+++ b/panels_ipe/src/Form/PanelsIPEBlockPluginForm.php
@@ -1,5 +1,10 @@
+/**
+ * @file
+ * Contains \Drupal\panels_ipe\Form\PanelsIPEBlockPluginForm.
+ */
+

Unneeded. Remove it

+++ b/panels_ipe/src/Form/PanelsIPELayoutForm.php
@@ -1,5 +1,10 @@
+/**
+ * @file
+ * Contains \Drupal\panels_ipe\Form\PanelsIPELayoutForm.
+ */

Unneeded. Remove it

+++ b/panels_ipe/src/PanelsIPEBlockRendererTrait.php
@@ -1,5 +1,10 @@
+/**
+ * @file
+ * Contains \Drupal\panels_ipe\PanelsIPEBlockRendererTrait.
+ */

Unneeded. Remove it from other places as well.

This was removed as part of #2769163: @file docblock as per [#2665992], [#2304909]

Comment #13

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 18:00

Noted; doing that.

Thank you Naveen.

Rewarded time I had working on this :)

Comment #14

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha as a volunteer commented 3 October 2016 at 18:05

Opened an issue at upstream so that we don't have to fix it at our end in next release #2810643: Fix coding style to meet Drupal standards

Comment #15

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 October 2016 at 18:11

Ok then. Good.
Following with that.

Comment #16

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 4 October 2016 at 19:21

Status:

Needs work

» Needs review

Comment #17

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 14 February 2017 at 21:20

Status:

Needs review

» Postponed

Lets get #2810643: Fix coding style to meet Drupal standards committed first so that this can be a smaller patch that deals with the actual changes rather than just coding standard fixes.