This module already calls filter_dom_serialize(filter_dom_load($text)) on the markup. We could ideally work directly with the dom rather than relying on regex for all the markup transformation.

CommentFileSizeAuthor
#11 2809717.patch7.58 KBmfb
#9 2809717.patch4.7 KBmfb
#7 2809717.patch6.94 KBmfb
#5 2809717.patch6.91 KBmfb
#3 2809717.patch4.7 KBmfb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfb created an issue. See original summary.

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented

Started on this in #1155774: Every image are resized but ideally all the tag processing could happen in this loop

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented

 

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Active » Needs review
FileSize
2809717.patch4.7 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2809717.patch, failed testing. View results

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs work » Needs review
FileSize
2809717.patch6.91 KB

Debug test which passes locally

Status: Needs review » Needs work

The last submitted patch, 5: 2809717.patch, failed testing. View results

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs work » Needs review
FileSize
2809717.patch6.94 KB

Status: Needs review » Needs work

The last submitted patch, 7: 2809717.patch, failed testing. View results

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs work » Needs review
FileSize
2809717.patch4.7 KB

Fun, I guess there is a whitespace bug in the libxml2 version 2.9.4 used by testbot - see e.g. https://bugs.php.net/bug.php?id=78129

Should be resolved if/when testbot upgrades to current release of debian..

Status: Needs review » Needs work

The last submitted patch, 9: 2809717.patch, failed testing. View results

mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs work » Needs review
FileSize
2809717.patch7.58 KB

And I uploaded wrong patch

  • mfb committed 8ba7c7e on 7.x-1.x, 8.x-1.x 
    Issue #2809717 by mfb: Use dom rather than regex for markup...
  • mfb committed 8ba7c7e on 7.x-1.x, 8.x-1.x
    Issue #2809717 by mfb: Use dom rather than regex for markup...
mfb’s picture

mfb
they or he
CreditAttribution: mfb commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.