It's still the same problem for me as described in https://www.drupal.org/node/2448449

The fixes which have been made in the ticket above are in the current version of drupal 8.0.x I use but the empty paragrpah bug still appears.

Comments

TiMESPLiNTER created an issue. See original summary.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

What is the exact version of Drupal you are running?

TiMESPLiNTER’s picture

TiMESPLiNTER CreditAttribution: TiMESPLiNTER as a volunteer commented

Good question seems that I messed up the versions... it's actually 8.1.10 not 8.0.x as stated above.

TiMESPLiNTER’s picture

TiMESPLiNTER CreditAttribution: TiMESPLiNTER as a volunteer commented
Version: 8.0.x-dev » 8.1.x-dev
TiMESPLiNTER’s picture

TiMESPLiNTER CreditAttribution: TiMESPLiNTER as a volunteer commented
Version: 8.1.x-dev » 8.1.10
thpoul’s picture

thpoul CreditAttribution: thpoul at Pixual commented

As mentioned at #2448449-7: CKEditor Widgets upcasting causes empty paragraph tags to be inserted this is not a bug in core, although just in case can you provide the steps to reproduce?

TiMESPLiNTER’s picture

TiMESPLiNTER CreditAttribution: TiMESPLiNTER as a volunteer commented

Okay so probably I should move this ticket to the entity_embed module then.

The steps to reproduce are the following:

  1. Install the entity_embed module
  2. Add an embed button to ckeditor
  3. Edit some sort of content (e.x. Basic page)
  4. Click the embed button I added in step 2 to ckeditor
  5. Choose an entity to embed
  6. Save it
  7. Visit the content (in my case the Basic page) you just embedded the entity in it
  8. There will be the rendered entity and an empty paragraph (< p>< /p>) below it
Gaelan’s picture

Gaelan CreditAttribution: Gaelan as a volunteer and at Google Code-In commented
Project: Drupal core » Entity Embed
Version: 8.1.10 » 7.x-3.x-dev
Component: ckeditor.module » Code

Moving to Entity Embed.

Gaelan’s picture

Gaelan CreditAttribution: Gaelan as a volunteer and at Google Code-In commented
Version: 7.x-3.x-dev » 8.x-1.x-dev

Oops.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano at Lullabot commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +D8Media

I cannot reproduce this problem, could you please test again with -dev versions of all modules and report back if that is the case?

trackleft2’s picture

trackleft2 CreditAttribution: trackleft2 commented

This is an issue with the latest version of entity_embed 7.x-3.x-dev, editor 7.x-1.0-alpha7, and Drupal 7.56 with the core patch here:
https://www.drupal.org/files/issues/do-2105841_no_protocol_filter-97.patch as well.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)
Issue tags: +Media Initiative

Like #10, I tried to reproduce, and can't. They must be either on Drupal 7, on an old Entity Embed version, the old JS must still be cached. This was fixed in https://github.com/drupal-media/entity_embed/pull/135 (back when this module was still being developed on GitHub).

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#2983766: Cant remove space between media entities in ckeditor
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#2448449: CKEditor Widgets upcasting causes empty paragraph tags to be inserted