Looks like the files in the directories module_name/assets/css and /js bootstrap.min.css, bootstrap.min.js respectively are never used / referenced in the code. Instead, the module is referencing them as CDN. It would be better if the dependency on bootstrap files is met using library 'sites/all/libraries/' or taken care by the bootstrap_library module.

CommentFileSizeAuthor
#3 2808875-3.patch13.42 KBrasikap

Comments

vishwac9 created an issue. See original summary.

rasikap’s picture

rasikap commented
Assigned: Unassigned » rasikap
rasikap’s picture

rasikap commented
Assigned: rasikap » Unassigned
StatusFileSize
new 2808875-3.patch13.42 KB

I have removed the mentioned files bootstrap.min.css and bootstrap.min.js.

joris_lucius’s picture

joris_lucius
Primary language Dutch
commented

Hi vishwac9, rasikap,

Thanks for the input, we'll process it with next update

-- Best, Joris

rasikap’s picture

rasikap commented
Status: Active » Needs review

  • Erik de Kamps committed 9085a96 on 7.x-1.x authored by rasikap 
    Issue #2808875 by rasikap: Remove unused files bootstrap.min.css and...
erik de kamps’s picture

erik de kamps commented
Status: Needs review » Fixed

Hi vishwac9, rasikap,

Thank you for the patch, it has been applied in 7.x-1.1.

Kind regards,
Erik de Kamps

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.