Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up to #2757749-6: Remove @file tag docblock
phpcbf --standard=Drupal refreshless/
Comment | File | Size | Author |
---|---|---|---|
#23 | appliedMR.png | 64.61 KB | roberttabigue |
Issue fork refreshless-2808811
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Wim LeersThese need work.
This is just making a stubbed comment more inconsistent.
This sentence was incomplete. My bad, of course! Just putting a period there doesn't help :)
Comment #3
Wim LeersI forgot to say: thanks! :)
Comment #4
naveenvalecha<3 ;)
Adding Novice tag
Comment #5
minakshiPh CreditAttribution: minakshiPh at Iksula commentedComment #6
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded the patch with fix as mentioned in #2
Kindly review.
Thanks!
Comment #7
Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at Drupal Partners commentedComment #8
Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at Drupal Partners commentedThe changes contained in the patch looks good to me.
Comment #9
Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at Drupal Partners commentedComment #10
Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at Drupal Partners commentedComment #11
RajeshreeputraComment #12
anoopsingh92+1 RTBC
Comment #13
Rajeshreeputrabelow lines from patch doesn't make sense to me specially the special character(…)).
and
can we have MR for the same.
Comment #15
anoopsingh92Made the changes and remove the special character(…). Please review and merge the MR.
Thank you
Comment #16
irfan.gul CreditAttribution: irfan.gul at Axelerant commentedThe changes in the patch looks good to me.
Comment #17
Rajeshreeputrathe patch provided in #6 and MR is different.
Comment #18
rishu_kumar CreditAttribution: rishu_kumar commentedI've created a patch.
Comment #19
rishu_kumar CreditAttribution: rishu_kumar at QED42 commentedtagging my organization.
Comment #20
anoopsingh92Hi everyone, MR is opened, Please update the MR. you can commit and push the changes in the ticket branch.
Thank you
Comment #21
Ambient.ImpactThis looks great at first glance - especially the proper dependency injection. I'll try and find the time in the next few days to give it a test run locally. Hiding the patches in favour of the issue fork.
Comment #22
Ambient.ImpactSo I was thinking to myself that I never really was a fan of uppercase
NULL
,TRUE
, orFALSE
in either JavaScript or PHP, but didn't have the time right now to get into it, and figured the JavaScript was going to get totally rewritten for the Symfony UX Turbo port. Then I tried this and was reminded that uppercaseNULL
,TRUE
, andFALSE
in JavaScript are treated as variables or constants unlike in PHP, so uppercasing them results in errors because they no longer refer to null or boolean values, since JavaScript is a case sensitive language that way.Anyways, after reverting that, the JavaScript mostly works again, though there's some weirdness with updating URLs in the location bar but I haven't looked at RefreshLess in half a year so it's possible that's related to changes in Drupal core or something else.
I'm a bit confused how the coding standards for PHP (I assume) got applied to a JavaScript file?
Comment #23
roberttabigue CreditAttribution: roberttabigue at Promet Source commentedHi,
I reviewed the changes and confirmed the latest MR was applied cleanly.
And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
Applied to Refreshless module with 8.x-1.x-dev version and with the Drupal core version of 9.5.x.
Attaching a screenshot and moving this to RTBC,
Thanks.
Comment #26
Ambient.ImpactMerged to 2.x. Thanks everyone!