Having the Crop admin UI under admin/structure seems rather out of place, as that's mostly entity bundles and views.

admin/config/media seems like the logical place to me.

CommentFileSizeAuthor
#4 crop-admin-ui-path-2808671-4.patch5.5 KBSteffenR
#2 crop-admin-ui-path-2808671-2.patch5.06 KBzerolab
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

zerolab’s picture

zerolab CreditAttribution: zerolab at Torchbox commented
Status: Active » Needs review
Issue tags: +Dublin2016
FileSize
crop-admin-ui-path-2808671-2.patch5.06 KB

Makes perfect sense. Here's a quick patch.

SteffenR’s picture

SteffenR
Primary language English
Location Bremen
CreditAttribution: SteffenR at undpaul commented
Assigned: Unassigned » SteffenR

I'll take it for review.

SteffenR’s picture

SteffenR
Primary language English
Location Bremen
CreditAttribution: SteffenR at undpaul commented
FileSize
crop-admin-ui-path-2808671-4.patch5.5 KB

I just reviewed the patch. You were missing to change configuration in crop.links.menu.yml. This config moves the menu links to media fieldset on the admin/config page. You patch only changed the routes directly.

I added a new parent in crop.links.menu.yml - now it should be fine for everyone.

Please review again.

SteffenR’s picture

SteffenR
Primary language English
Location Bremen
CreditAttribution: SteffenR at undpaul commented
Assigned: SteffenR » Unassigned
zerolab’s picture

zerolab CreditAttribution: zerolab at Torchbox commented
Status: Needs review » Reviewed & tested by the community

Good catch!

Looks good to me.

  • slashrsm committed 7e239c7 on 8.x-1.x authored by zerolab 
    Issue #2808671 by SteffenR, zerolab: Move crop admin UI to admin/config/...
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +D8Media

Committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alphex’s picture

alphex CreditAttribution: alphex commented

You also need to fix the documentation.