Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a really, really minor thing...but it bugs the hell out of me and it has been for a while. Can we, like, give Migrate's Row class default constructor arguments so that in testing we don't always have to write new Row([], [])
? Seriously minor...but it drives me crazy. If it annoys anybody else, by all means chime in so I don't feel like a weird neat freak.
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff.txt | 645 bytes | quietone |
#3 | 2808329-3.patch | 11.04 KB | quietone |
#2 | 2808329-2.patch | 10.74 KB | phenaproxima |
Comments
Comment #2
phenaproximaComment #3
quietone CreditAttribution: quietone as a volunteer commentedSimple this may be but it does help. Plus, I reckon helping phenaproxima's to keep his sanity is a good thing.
New patch because after applying the patch grep reported an instance of "new Row([], [])".
Comment #4
phenaproximaComment #5
benjy CreditAttribution: benjy at PreviousNext commentedThis is a funny one, Row is an internal object to Migrate, nobody should be instantiating their own so I can't see any issues with this.
Comment #6
alexpottCommitted and pushed d11cc0a to 8.3.x and 0cf889e to 8.2.x. Thanks!
And even if someone was using it - supplying defaults is not going to break a thing. The signature has not really changed.
Fixed on commit.