Improve captcha_install(), correctly create dynamic captcha points, move static captcha points to default config

This could be a core issue, facets also has that I think.

  foreach ($form_ids as $form_id) {
    $values = [
      'formId' => $form_id,
      'captchaType' => 'default',
      'status' => FALSE,
    ];
    $captcha_point = new CaptchaPoint($values, 'captcha_point');
    $captcha_point->trustData()->save();
  }

This is wrong.

Must use $storage->create().

Looks correct.

Thanks committed and pushed to 8.x-1.x
Also removed the unused statement at commit.See in the interdiff attached

Didn't get to review.

We could get the storage out of the loop as a tiny improvement.

Also, the current logic will break trying to install captcha as part of a config deployment. The hardcoded form ids could be just default configuration in the module. the dynamic node type based ones are a bit tricky, we could either remove them or at least check for a sync, see forum_install().

And the drupal_set_message()'s there are IMHO also a bad idea. The second one is broken anyway (page cache is a module now, not a setting) and the first is weird when installing it in a config sync or install profile. Other modules don't do this either, the modules page has links to settings and help built-in.

Reverting this for now to get this fixed in appropriate way as per #8. Config sync would be right improvement to fix the config deployment.

Looks good to me.