The unit tests of Image's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.

CommentFileSizeAuthor
#6 2807893-6.patch7.2 KBsvendecabooter
#3 2807893-3.patch7.13 KBsvendecabooter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
Assigned: Unassigned » svendecabooter
svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
Assigned: svendecabooter » Unassigned
Status: Active » Needs review
FileSize
2807893-3.patch7.13 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

See #2807879-14: Convert Contact's Migrate source tests to new base class - let's use better array keys to make it easier to understand what is going on.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
Status: Needs work » Needs review
FileSize
2807893-6.patch7.2 KB

Updated the patch to have more informative keys (next to descriptive comments) as suggested by alexpott

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thank you, svendecabooter.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 7f4e7eb to 8.3.x and 995ab3a to 8.2.x. Thanks!

  • alexpott committed 7f4e7eb on 8.3.x 
    Issue #2807893 by svendecabooter: Convert Image's Migrate source tests...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.