The unit tests of Block's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.

CommentFileSizeAuthor
#9 2807855-9.patch6.51 KBsvendecabooter
#5 2807855-5.patch6.39 KBmaijs
#2 2807855-2.patch6.39 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
Issue tags: +Dublin2016
FileSize
2807855-2.patch6.39 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2807855-2.patch, failed testing.

The last submitted patch, 2: 2807855-2.patch, failed testing.

maijs’s picture

maijs CreditAttribution: maijs at Wunder commented
FileSize
2807855-5.patch6.39 KB

Class namespace is incorrect in patch in #2 (namespace Drupal\Tests\block\Unit\Plugin\migrate\source instead of namespace Drupal\Tests\block\Kernel\Plugin\migrate\source), hence tests failing. This patch fixes that.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Another one done. Much easier to read as well.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

See #2807879-14: Convert Contact's Migrate source tests to new base class - let's use better array keys to make it easier to understand what is going on.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
Status: Needs work » Needs review
FileSize
2807855-9.patch6.51 KB

Updated the patch to have more informative keys (next to descriptive comments) as suggested by alexpott

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

thanks again.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 62c9422 to 8.3.x and 2ba14bb to 8.2.x. Thanks!

  • alexpott committed 62c9422 on 8.3.x 
    Issue #2807855 by phenaproxima, maijs, svendecabooter: Convert Block's...

  • alexpott committed 2ba14bb on 8.2.x 
    Issue #2807855 by phenaproxima, maijs, svendecabooter: Convert Block's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.