Client side validation and Authcache don't play well. [#2807483]

Im not sure where to open this issue with the Client Side Validation module or here.

Console error.

       $.each(Drupal.settings.clientsideValidation.forms, function (f) {
          if ($(context).find('#' + f).length || $(context).is('#' + f)) {
            update = true;
          }
        });

When authcache runs authcacheP13nReplaceWith the above Client Side Validation JS throws the following error.

TypeError: t.getAttribute is not a function. (In 't.getAttribute("id")', 't.getAttribute' is undefined)

Comment	File	Size	Author
#5	Screen Shot 2016-09-29 at 2.13.30 PM.png	451.5 KB	lathan
#5	Screen Shot 2016-09-29 at 2.13.07 PM.png	148.6 KB	lathan
#3	2807483-attach-elements-only.diff	904 bytes	znerol
#3	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass PHP 7 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks
	Screen Shot 2016-09-27 at 5.40.29 PM.png	105.14 KB	lathan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 September 2016 at 20:41

lathan created an issue. See original summary.

Comment #2

lathan

Chile

CreditAttribution: lathan as a volunteer commented 27 September 2016 at 22:20

Maybe just note this some where... I made a choice between the two and was thankfully easy enough to remove clientside validation from my stack.

Comment #3

znerol CreditAttribution: znerol commented 28 September 2016 at 05:38

Status:

Active

» Needs review

File	Size
2807483-attach-elements-only.diff	904 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass PHP 7 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Nice catch. I think that might be a combination of bugs in Authcache and Client Side Validation.

Authcache probably should only call Drupal.attachBehaviors for HTML elements. It looks like it also tries to attach text nodes.
Client Side Validation shouldn't use $(context).find(selector) but rather $(selector, context).

Patch attached for the first problem. Do you mind applying the patch and then report back whether it resolves the incompatibility?

Comment #4

lathan

Chile

CreditAttribution: lathan as a volunteer commented 28 September 2016 at 15:03

@znerol I owe you a beer, I will get back to you at the soonest.

File	Size
Screen Shot 2016-09-29 at 2.13.07 PM.png	148.6 KB
Screen Shot 2016-09-29 at 2.13.30 PM.png	451.5 KB

Comment #6

znerol CreditAttribution: znerol commented 29 September 2016 at 18:44

Interesting. Do you mind checking which data is causing that trouble?

Maybe add a console.log statement in authcache_p13n.js:

$elem.each(function() {
  console.log(this) // <- add this line to debug or set a breakpoint and examine the contents of the this-variable.
  Drupal.attachBehaviors(this);
});

Comment #7

znerol CreditAttribution: znerol commented 5 October 2016 at 07:28

Status:

Needs review

» Postponed (maintainer needs more info)

I tried to reproduce this problem with Chrome and Firefox to no avail. Which browser/OS do you use? Is there any standard Drupal form where the problem occurs (e.g., the contact form or the comment form)?