CommentFileSizeAuthor
#40 use_only_one_template-2807357-40.patch29.55 KBborisson_
#37 use_only_one_template-2807357-37.patch28.73 KBborisson_
#37 interdiff.txt834 bytesborisson_
#34 use_only_one_template-2807357-34.patch28.73 KBborisson_
#34 interdiff.txt973 bytesborisson_
#31 use_only_one_template-2807357-31.patch28.31 KBborisson_
#31 interdiff.txt2.89 KBborisson_
#28 use_only_one_template-2807357-28.patch27.37 KBborisson_
#28 interdiff.txt18.64 KBborisson_
#25 use_only_one_template-2807357-25.patch10.17 KBborisson_
#25 interdiff.txt840 bytesborisson_
#22 use_only_one_template-2807357-22.patch10.17 KBborisson_
#22 interdiff.txt5.42 KBborisson_
#19 use_only_one_template-2807357-19.patch7.69 KBborisson_
#19 interdiff.txt2.34 KBborisson_
#16 use_only_one_template-2807357-16.patch11.13 KBborisson_
#16 interdiff.txt5.77 KBborisson_
#13 use_only_one_template-2807357-13.patch5.35 KBborisson_
#13 interdiff.txt2.69 KBborisson_
#10 use_only_one_template-2807357-8.patch3.56 KBborisson_
#7 use_only_one_template-2807357-7.patch10.22 KBborisson_
#7 interdiff.txt6.67 KBborisson_
#5 use_only_one_template-2807357-5.patch3.54 KBborisson_
#3 use_only_one_template-2807357-2.patch2.43 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_ credited MathieuSpil.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Active » Needs review
FileSize
use_only_one_template-2807357-2.patch2.43 KB

Status: Needs review » Needs work

The last submitted patch, 3: use_only_one_template-2807357-2.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
FileSize
use_only_one_template-2807357-5.patch3.54 KB

The last submitted patch, 3: use_only_one_template-2807357-2.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt6.67 KB
use_only_one_template-2807357-7.patch10.22 KB

Make tests at least somewhat more happy.

Status: Needs review » Needs work

The last submitted patch, 7: use_only_one_template-2807357-7.patch, failed testing.

The last submitted patch, 7: use_only_one_template-2807357-7.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
use_only_one_template-2807357-8.patch3.56 KB

Changed the class names after discussion with @StryKaizer.

Status: Needs review » Needs work

The last submitted patch, 10: use_only_one_template-2807357-8.patch, failed testing.

The last submitted patch, 10: use_only_one_template-2807357-8.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt2.69 KB
use_only_one_template-2807357-13.patch5.35 KB

Status: Needs review » Needs work

The last submitted patch, 13: use_only_one_template-2807357-13.patch, failed testing.

The last submitted patch, 13: use_only_one_template-2807357-13.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt5.77 KB
use_only_one_template-2807357-16.patch11.13 KB

Should fix more tests.

Status: Needs review » Needs work

The last submitted patch, 16: use_only_one_template-2807357-16.patch, failed testing.

The last submitted patch, 16: use_only_one_template-2807357-16.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt2.34 KB
use_only_one_template-2807357-19.patch7.69 KB

Interdiff is not very useful I guess. But I changed the assertLink method to fit our needs + added a new testmethod to check for active facets. Let's see what else in the testsuite needs updating.

Status: Needs review » Needs work

The last submitted patch, 19: use_only_one_template-2807357-19.patch, failed testing.

The last submitted patch, 19: use_only_one_template-2807357-19.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt5.42 KB
use_only_one_template-2807357-22.patch10.17 KB

Status: Needs review » Needs work

The last submitted patch, 22: use_only_one_template-2807357-22.patch, failed testing.

The last submitted patch, 22: use_only_one_template-2807357-22.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt840 bytes
use_only_one_template-2807357-25.patch10.17 KB

Fixes xpath?

Status: Needs review » Needs work

The last submitted patch, 25: use_only_one_template-2807357-25.patch, failed testing.

The last submitted patch, 25: use_only_one_template-2807357-25.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt18.64 KB
use_only_one_template-2807357-28.patch27.37 KB

More work

Status: Needs review » Needs work

The last submitted patch, 28: use_only_one_template-2807357-28.patch, failed testing.

The last submitted patch, 28: use_only_one_template-2807357-28.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt2.89 KB
use_only_one_template-2807357-31.patch28.31 KB

Status: Needs review » Needs work

The last submitted patch, 31: use_only_one_template-2807357-31.patch, failed testing.

The last submitted patch, 31: use_only_one_template-2807357-31.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
interdiff.txt973 bytes
use_only_one_template-2807357-34.patch28.73 KB

Status: Needs review » Needs work

The last submitted patch, 34: use_only_one_template-2807357-34.patch, failed testing.

The last submitted patch, 34: use_only_one_template-2807357-34.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
Issue tags: +Dublin2016
FileSize
interdiff.txt834 bytes
use_only_one_template-2807357-37.patch28.73 KB

Status: Needs review » Needs work

The last submitted patch, 37: use_only_one_template-2807357-37.patch, failed testing.

The last submitted patch, 37: use_only_one_template-2807357-37.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs work » Needs review
FileSize
use_only_one_template-2807357-40.patch29.55 KB

  • borisson_ committed 24a9026 on 8.x-1.x 
    Issue #2807357 by borisson_, MathieuSpil: Use only one template instead...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs review » Fixed

Rough to get to this, but it works! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.