In user.module we are calling \Drupal::languageManager() twice. Seems unnecessary.

CommentFileSizeAuthor
#2 reduce_duplication_in-2806523-2.patch707 byteseiriksm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eiriksm created an issue. See original summary.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS commented
Status: Active » Needs review
Issue tags: +Novice
FileSize
reduce_duplication_in-2806523-2.patch707 bytes
xito’s picture

xito CreditAttribution: xito as a volunteer and at NTT DATA commented
Status: Needs review » Reviewed & tested by the community

I saw that the duplicate call has been removed in user_name, so I am going to to propose to be tested and reviewed by the community.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 3153a4e and pushed to 8.3.x. Thanks!

  • alexpott committed 3153a4e on 8.3.x 
    Issue #2806523 by eiriksm: Reduce duplication in user_mail

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.