mbase crashes due to [] [#2805647]

PHP message: PHP Fatal error: [] operator not supported for strings in sites/all/themes/mbase/includes/helper.inc on line 1577

Original code

$link['attributes']['class'][] = 'btn'; // row 1577 crashes due to not initialised as array
$link['attributes']['class'][] = 'btn-xs';

Quickfix
$link['attributes']['class'] = array($link['attributes']['class'],'btn');
$link['attributes']['class'][] = 'btn-xs';

Comment	File	Size	Author
#8	mbase-2805647-8.patch	1.19 KB	pifagor
#7	mbase-2805647-7.patch	1.19 KB	pifagor
#3	mbase-2805647-3.patch	600 bytes	pifagor

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

24 September 2016 at 12:44

arne_hortell created an issue. See original summary.

Comment #2

arne_hortell CreditAttribution: arne_hortell commented 24 September 2016 at 13:28

It also requires to check IF ['class'] exists...

File	Size
mbase-2805647-3.patch	600 bytes

Comment #4

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor commented 24 September 2016 at 14:15

Status:

Active

» Needs review

Comment #5

arne_hortell CreditAttribution: arne_hortell commented 25 September 2016 at 06:59

// with no check if 'class' exists it gives notice message...
// creates typecasting if $link['attributes']['class'] is defined but is a string
if (array_key_exists('class',$link['attributes']))
$link['attributes']['class'] = array($link['attributes']['class'],'btn');
else
$link['attributes'][] = array('class'=>'btn');

Comment #6

arne_hortell CreditAttribution: arne_hortell commented 25 September 2016 at 12:30

More fixinig needed for mbase

Row 78 and forward should be

function _mbase_smart_region(&$var, $regions, $theme) {
foreach ($regions as $region) {
$drupal_block=false; // added by me
if (array_key_exists($region,$var['page'])) // added by me
$drupal_block = $var['page'][$region];
// Display the block if it exists.