Cross-posting a D8 issue. #2703771: Views argument set incorrectly when using AJAX pagination and a path alias

Haven't tested this in D7, but I suspect the same issue applies given how similar the JS code is for both.

CommentFileSizeAuthor
#15 views-n2805539-15.patch5.11 KBDamienMcKenna
#10 2805539-js-views-arg-10.patch767 bytesron_s
#2 2805539-js-views-arg-2.patch539 bytesSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented
FileSize
2805539-js-views-arg-2.patch539 bytes
Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented
Status: Active » Needs review
Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented
Related issues: +#2703771: Views argument set incorrectly when using AJAX pagination and a path alias
riddhi.addweb’s picture

riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented
Issue tags: +Ajax, +view arguments
qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko as a volunteer and at DrupalJedi commented
Status: Needs review » Reviewed & tested by the community

I confirm problem with Ajax Views and GET arguments in url. Clicking on "First", "1" links in pager is not working.
Patch testing:

qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko as a volunteer and at DrupalJedi commented
Related issues: +#1786524: AJAX pager does not work if page number set in URL

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2805539-js-views-arg-2.patch, failed testing. View results

xyxxznpm’s picture

xyxxznpm CreditAttribution: xyxxznpm as a volunteer commented

The patch in #2 does not work for me. My case is after using load more button the currentpath=views/ajax, not the real path alias. Continue search.....

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Status: Needs work » Needs review
FileSize
2805539-js-views-arg-10.patch767 bytes

The patch in #2 no longer applies cleanly to the latest Views release due to changes in spacing and additional lines.

Have created a new version for review, see attached.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck at Four Kitchens commented
Status: Needs review » Reviewed & tested by the community

We've been using this on production since November. Simple, elegant and works.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Really worked

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Any thoughts on test coverage for this? Are there any chances of regressions from the change?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

FYI the code this changes has existed like this since it was originally written in 2011 in #1294636: Objectify ajax_view.js. Should we be concerned at other uses of Drupal.Views.parseViewArgs()?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue tags: +Needs tests
FileSize
views-n2805539-15.patch5.11 KB

Starting on test coverage.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 15: views-n2805539-15.patch, failed testing. View results