Problem/Motivation

Port Imgix to Drupal 8.

An initial port is available on the sandbox at https://www.drupal.org/sandbox/spoit/2805401.

Remaining tasks

  • Test webfolder en webproxy folder as imgix sources
  • Find out if the s3 source is usable without an s3 file replacement such as flysystem
  • Remove the config presets code since the code leans on default image styles now
  • Find out if using theme_alter and removing theme_image_styles preprocess functions has unwanted side effects.

User interface changes

Not a lot. The admin page stays the same. The rendering reads the current image style for a image field and then *tries* to convert that image style to imgix parameters.

Original report by spoit

Hi,

I took what was there in the 7.x branch and made a working version for 8.x. Since we use flysystem_s3 as our file system, I did not test *yet* with Imgix webfolder/webproxy sources.

The 8.x version alters theme_imagestyle, adds a custom theme function and removes all preprocess functions. The module tries then to read the selected image style and tries to convert the effects of the style to imgix parametes.

I can create a patch out of the sandbox if needed (unsure how the process goes here), but I suspect the maintainer first needs to create a 8.x branch?

Comments

spoit created an issue. See original summary.

spoit’s picture

Issue summary: View changes
spoit’s picture

Issue summary: View changes
tregismoreira’s picture

Hey @spoit! Sorry for the late, I was stuck in a project.

You did a really great job. The code is so well organised and commented. Congrats and thanks! :)

I didn't tested yet, but for sure we have to make it a release for this project. As I couldn't work on it right now, I'll make you co-maintainer. What do you think? :)

spoit’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
tregismoreira’s picture

Status: Needs review » Fixed

@spoit, the first beta release for Drupal 8 version, based on your code, is released: https://www.drupal.org/project/imgix/releases/8.x-1.0-beta1

Thanks for your contribution ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.