Follow-up to #2780093: Have simpletest, run-tests.sh enforce their dependency on PHPUnit

Problem/Motivation

We want d.o to ship a tarball without dev dependencies, for a variety of reasons including security. This means we have to change the build process so it uses composer install --no-dev: #2745355: Use "composer install --no-dev" to create tagged core packages

#2780093: Have simpletest, run-tests.sh enforce their dependency on PHPUnit committed a change which caused simpletest and run-tests.sh to enforce their dependency on phpunit for 8.2.x and higher branches.

This issue does the same for 8.1.x.

Proposed resolution

  • Add a PHPUnit check to simpletest_requirements().
  • Add a PHPUnit check to run-tests.sh.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2804663_2.patch1.56 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Status: Active » Needs review
FileSize
1.56 KB

As it turns out, the same patch as #2780093-11: Have simpletest, run-tests.sh enforce their dependency on PHPUnit #11 applies to 8.1.x.

Unfortunately we can't run tests against 8.1.x in the issue.

dawehner’s picture

Why do we need the same for 8.1.x given that 8.1.x is basically end of life now

Mile23’s picture

8.1.x just had a release yesterday...

dawehner’s picture

I thought though that we are not longer committing stuff to 8.1.x basically.

pfrenssen’s picture

Status: Needs review » Closed (won't fix)

8.1.x is now EOL, this is not needed any more.