Well, every submitted patch ends up in "waiting for branch to pass" - the failed branch test is at https://www.drupal.org/pift-ci-job/448645:

Migrate_plus.Drupal\migrate_plus\Tests\MigrationGroupTest
testConfigurationMerge

fail: [Other] Line 22 of modules/migrate_plus/src/Tests/MigrationGroupTest.php:
Drupal\migrate_plus\Tests\MigrationGroupTest::testConfigurationMerge
Argument 1 passed to Drupal\migrate\Plugin\Migration::getProcessNormalized() must be of the type array, null given, called in /var/www/html/core/modules/migrate/src/Plugin/Migration.php on line 685 and defined

It's time I fixed that...

Comments

mikeryan created an issue. See original summary.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented

Oh, that was an older failure, currently we're getting a CI error since #2764547: PHPUNIT doesn't see migrate_plus tests.: ERROR: No valid tests were specified.

  • mikeryan committed bd2f7b0 on 8.x-2.x 
    Issue #2803259 by mikeryan: Fix failing tests
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Status: Active » Fixed

Committed, and the branch has passed. There were two issues:

1. The DrupalCI error in the first comment was a bad namespace in the moved tests.
2. That resurfaced the error in the issue summary, which was a missing 'process' in the test migration.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.