Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

legolasbo’s picture

Status: Active » Needs work

This seems to be the wrong patch

nehakhadke’s picture

legolasbo’s picture

Version: 8.x-3.x-dev » 8.x-1.x-dev

8.x-3.x-dev is not under development.

wve22358’s picture

Status: Needs work » Needs review
FileSize
0 bytes

Status: Needs review » Needs work

The last submitted patch, 6: ReadmeFile_Drupal8-2802761-1.patch, failed testing. View results

wve22358’s picture

Status: Needs work » Needs review
FileSize
2.17 KB
legolasbo’s picture

Status: Needs review » Needs work

I've reviewed your patch. Please see my findings below and Thank you for your contribution.

  1. +++ b/README.txt
    @@ -0,0 +1,72 @@
    + * To enable this module, find it under "Fields" in the Admin menu.
    

    How do you mean find it under fields?

  2. +++ b/README.txt
    @@ -0,0 +1,72 @@
    +Previous maintainer(s):
    +Daniel Braksator (http://drupal.org/user/134005)
    \ No newline at end of file
    

    Daniel never maintained the D8 version. You're also missing a newline at the end of the file.

wve22358’s picture

Status: Needs work » Needs review
FileSize
582 bytes
2 KB
legolasbo’s picture

Status: Needs review » Needs work

That's looking a lot better, but I'm missing instructions on how to actually use it for a field. Could you extend the usage suggestions with an example of how It could be configured?

wve22358’s picture

Status: Needs work » Needs review
FileSize
1.57 KB
2.51 KB
legolasbo’s picture

Status: Needs review » Needs work
  1. +++ b/README.txt
    @@ -41,8 +39,26 @@ APPLICATIONS
    +This is an example to use the Field widget. First make sure you have a Taxonomy
    +term.
    

    I think you mean "First make sure you have a taxonomy vocabulary"

  2. +++ b/README.txt
    @@ -41,8 +39,26 @@ APPLICATIONS
    +1. Go to Structure and add a new Content type and add a field with field type
    +   Taxonomy term.
    

    This are two steps, not one.

  3. +++ b/README.txt
    @@ -41,8 +39,26 @@ APPLICATIONS
    +2. Edit this term and select "Create referenced entities if they don't already
    +   exist" and save.
    

    Edit the term? Shouldn't that be the field?

wve22358’s picture

FileSize
1022 bytes
2.56 KB

  • legolasbo committed 4b38268 on 8.x-1.x authored by wve22358
    Issue #2802761 by wve22358, legolasbo: README.txt File For Drupal 8
    
legolasbo’s picture

Status: Needs work » Fixed

Committed and pushed to 8.x-1.x, thanks for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.