On multiple aegir servers I have 7.x-3.7 installed with the following backup related modules installed:

  • Backup queue
  • Backup window
  • Hosting Site Backup Manager

In a previous version, it was possible to disable backups on a specific site in order to stop it from making automated backups and it would stay disabled. However, until recently (possibly starting with the 7.x-3.7 version), after verifying a site that has backups disabled, it reverts back to "enabled" automatically.

For now, I am manually deleting the backups, however it would be great to have it disabled again. Thanks in advanced. Please let me know if you need anything else to help debug further.

Comments

NWOM created an issue. See original summary.

nwom’s picture

Issue summary: View changes
helmo’s picture

Project: Provision » Hosting Site Backup Manager
Version: 7.x-3.7 » 7.x-3.x-dev

I think this is a result of a change in hosting_site_backup_manager

These settings and status were switched around to improve the UI.

helmo’s picture

Status: Active » Needs review
StatusFileSize
new2.61 KB

We had a duplicate in #2867233: Can't disable site backup and multiple backups being spawned for same site that fail where I started with a patch, but while working with a client I improved it a bit more.

Here's a patch...

northstowe’s picture

StatusFileSize
new2.63 KB

As I have already done the work I will include a patch to resolve this another way that matches what we feel is a more natural UI:

Only show options if user doesn't want the default
Only show interval if backups enabled

I was unable to find any comments on the change to improve the UI so there may be a valid reason for switching the order that I have missed.

Also includes a different solution to the stacked ternary operators.

Not sure of the protocol on naming alternative (rather than derivative) patches.

helmo’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new21.67 KB
new20.76 KB

To visualize it ....

#4:

#5:

I think I also prefer #5

  • helmo committed 6f9ac53 on 7.x-3.x authored by northstowe
    Issue #2802179 by helmo, northstowe: Disabling Automated Backups for...
helmo’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.