The "Shipping line item exists" rule currently allows checking to see if the shipping line item is for a single selected shipping service. This can get cumbersome if you want a rule that works for some (more than one, but not all) of the shipping services as you currently have to add this rules condition multiple times and wrap the conditions in an Or.

CommentFileSizeAuthor
#2 rules_shipping_exists_allow_multiple_provider_comparison-2801553-2.patch1.7 KBanemirovsky
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anemirovsky created an issue. See original summary.

anemirovsky’s picture

anemirovsky CreditAttribution: anemirovsky at Giant Rabbit, LLC commented
Status: Active » Needs review
FileSize
rules_shipping_exists_allow_multiple_provider_comparison-2801553-2.patch1.7 KB

This patch adds the ability to compare to multiple shipping services in one "Shipping line item exists" rules condition.

das-peter’s picture

das-peter CreditAttribution: das-peter at Cando commented
Status: Needs review » Needs work

I like the idea, but what about existing rules? Did you check if existing rules continue to work or if a re-save or something similar is needed?
We could use a parameter check like following to make it backward compatible: $services = (is_array($services)) ? $services : array($services);.
But I'm not sure how rules behaves if you just change the parameter type.