Problem/Motivation
Apologies if this has been reported before, in another form. I tried searching and didn't see any duplicates. I suspect the problem applies to multiple field types, not just images.
I've got a field with multiple images, that I need to appear in a specific order. I just got sent a series of replacement images, like so:
Image 1
Image 2
Image 3
Image 4
Image 5
to be replaced with
Image 1
Image 2a
Image 3
Image 4a
Image 5
If I first upload the images and move them into correct position, like so:
Image 1
Image 2
Image 2a
Image 3
Image 4
Image 4a
Image 5
And then click the Remove button to delete Image 2 and 4, the order I had just set up is lost and I'm left with:
Image 1
Image 3
Image 5
Image 2a
Image 4a
I obviously could just delete image 2 and 4 first, then upload. Or move the images into place after I deleted them. Or save the node before deleting them. I was kind of using the old images as a guide to know where the new ones were supposed to be placed.
Very minor, to be sure, but thought I'd report it. From a UI perspective it's a bit jarring.
Steps to reproduce
Proposed resolution
TBA
Remaining tasks
Search for duplicate issue
Write a test
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-2800981
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
vdanielpop CreditAttribution: vdanielpop at PitechPlus commentedComment #3
dashaxiong CreditAttribution: dashaxiong commentedI can confirm this issue. It also occurs when you upload a new image after dragging image fields. The current UI states a subdued warning "*you have unsaved changes". I think this might be solved if the script responsible for dragging fields around can update the
data-drupal-selector
. I am working on this issue.Comment #4
dashaxiong CreditAttribution: dashaxiong commentedIf we go with the option to update the
data-drupal-selector
(assuming for the moment that will solve the issue), it would mean that all the following field IDs would need to be updated at the same time. But the number of fields in any given set is unlikely to be too high so this should be okay.Comment #5
vdanielpop CreditAttribution: vdanielpop at PitechPlus commentedComment #6
vdanielpop CreditAttribution: vdanielpop at PitechPlus commentedComment #12
zanvidmar CreditAttribution: zanvidmar as a volunteer commentedComment #14
zanvidmar CreditAttribution: zanvidmar as a volunteer commentedComment #15
quietone CreditAttribution: quietone at PreviousNext commentedI took a very brief look at this.
@zanvidmar, thank you for making a patch! It would help to comment on what actions you took in making the patch. Such as did you confirm the problem still exists etc.
The issue summary is out of date, in particular there is no proposed resolution, which means that a reviewer will not know if the patch is doing what is intended. I added the standard template to the issue summary and tagged for an update.
Looking at the patch, there is no test, so adding tag for that.
And given the age of the issue, a search for duplicates should be done.