Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

IAmThatStrangeMe’s picture

Hi nehakhadke I really would like to use this but I'm so sorry I've no clue how to apply the patch. I downloaded the module and the patch but couldn't find any help.

Thanks

shobhit_juyal’s picture

I am subscribing this issue, as I download this module via drush and GUI, but it does not contains Drupal 8 file extensions. It is still having D7 files like "nivo_slider.info".

What its D8 realease contains those files ? Please suggest, if we can still work with those files in D7 !!.

dreamlabmedia’s picture

I have the same issue. I've seen other posts like this but no one has given a solution to this. I really liked nivosliver on older drupal installations. Please help.

When I try to install I get the following "nivo_slider-8.x-1.4.tar.gz does not contain any .info.yml files."

dreamlabmedia’s picture

I applied the patch nehakhadke provided and it did not work. To apply a patch you have to download the module and unzip to access the .info file. You rename the film to nivo_slider.info.yml and then open that file and add the patch by clicking on the patch link and you copy the content in that, and past it into the nivo_slider.info.yml file. Save that then rezip your nivoslider file and upload the module from your computer.

I found another patch I tried first which I was able to upload, but needed to install the dev version of Libraries API. I did that, then enabled the nivo module, but this broke my website giving me an error due to line 37 in the nivoslider module. So I had to manually delete the module to fix the website. So I tried adding nehakhadke's patch and I was not able to upload. It says it cannot upload.

So, I still haven't found a solution, but wanted to warn people that you might break your website. Uninstalling the module from inside drupal is also not working. At one point I had to manually upload the folder again, then delete it to get things working again.

Just putting this out there in case someone runs into this as I did.

nehakhadke’s picture

Status: Active » Needs work
MaskyS’s picture

Assigned: Unassigned » MaskyS
nehakhadke’s picture

MaskyS’s picture

dreamlabmedia, that is not how you apply a patch. Please have a look at the following link for more info. https://www.drupal.org/node/620014
However, nehakhadke's patch will not apply even if you applied the patch correctly. That is because the patch was generated in a wrong way. I'm currently working on the patch and will post it shortly. (Warning: I'll be posting testing patches here often, so please don't download as soon as it comes online. I post them here to pass them through simplytest.me, and if it doesn't work I or a GCI mentor should update this issue within a few hrs.)

MaskyS’s picture

Here is a patch that should replace .info with info.yml and also rename readme.txt to README.txt.

MaskyS’s picture

Yet another patch. The previous one wasn't working and I don't expect this one to either.

MaskyS’s picture

MaskyS’s picture

MaskyS’s picture

This patch should work!

EDIT: This patch will work correctly for offline use, which means that it will NOT work on simplytest.me(because stable versions are not supposed to be mutable). However, I have contacted the module creator about this and hopefully, he will release a new stable version soon to fix this.

MaskyS’s picture

Priority: Normal » Major
Status: Needs work » Needs review
denutkarsh’s picture

Status: Needs review » Needs work

@kifah-meeran I applied it to stable 8.x-1.4 version of this module using git and it failed. I am setting the issue status as "Needs Work" for now.

neerajpandey’s picture

Status: Needs work » Needs review

@denutkarsh I applied it too but it worked for me.
Changing the status to needs review.

MaskyS’s picture

Please make sure that you are using the 8.x-1.4 version of this module instead of 8.x-1.x. You HAVE to download from https://www.drupal.org/project/nivo_slider/releases/8.x-1.4 , otherwise, you won't get the correct version. Here are the exact steps to be followed(type in terminal):

1. wget https://ftp.drupal.org/files/projects/nivo_slider-8.x-1.4.tar.gz

OR

1. wget https://ftp.drupal.org/files/projects/nivo_slider-8.x-1.4.zip

This will download the zip or tar file depending on what option you choose. You should do this inside your /modules folder if you want to use the module right away or you will have to copy it later to the /modules. If you ARE SURE that you ALREADY have THE 8.x-1.4 version, then you do not need to do this step and the one that follows.

Use:

2. tar -xzvf nivo_slider-8.x-1.4.tar.gz

OR

2. unzip -j nivo_slider-8.x-1.4.zip

3. cd nivo_slider

4. wget https://www.drupal.org/files/issues/Renaming-and-Replacing-2800413-15.patch

5. git apply -v Renaming-and-Replacing-2800413-15.patch

That's it!

denutkarsh’s picture

@kifah-meeran Anyways it would be better if the current users can use the development release for this module until it becomes stable.

MaskyS’s picture

@denutkarsh The whole module is unusable right now, stable or dev version because there are a lot of files which are still d7(no .routing.yml, for example.). The last commit was one year ago, so I guess I'll have to work on the porting later on. :)

MaskyS’s picture

Assigned: MaskyS » Unassigned
andrey.troeglazov’s picture

Assigned: Unassigned » andrey.troeglazov
andrey.troeglazov’s picture

Assigned: andrey.troeglazov » Unassigned
Status: Needs review » Fixed

Info file is present in the dev version. Will roll stable release after .routing.yml is added.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.