Right now the Core and Site assignment plugins will create new "core" and "site" packages to contain suggested config.

If there is already a bundle_core or bundle_site package exported within the current bundle namespace, it would be better to assign the core and site config to those modules as new items.

This would prevent the problem of selecting the "core" package, clicking Write and having it overwrite the existing bundle_core module. It also provides a nicer user experience where auto-detected items from the Core and Site assignment plugins show up as newly detected values.

To prevent problems with existing bundle_core and bundle_site modules that do not want this behavior, we should probably add the shortname to the config settings for Core and Site so other names can be used if desired.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpotter created an issue. See original summary.

mpotter’s picture

Status: Active » Needs review
FileSize
4.05 KB

Here is a patch to reassign Core and Site to the proper bundle_* existing packages. Probably going to break some tests?

Status: Needs review » Needs work

The last submitted patch, 2: features_core_and_site_bundle-2799531-2.patch, failed testing.

mpotter’s picture

Status: Needs work » Postponed

Think this is failing tests because #2796695: Features are duplicated after update isn't committed yet. Will resubmit after that is done.

mpotter’s picture

Status: Postponed » Needs review

OK, other fixes have been committed, so let's run the tests on this patch again.

mpotter’s picture

Hmm, re-queing the previous test didn't seem to work, so lets post a new patch identical to #2

The last submitted patch, 2: features_core_and_site_bundle-2799531-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: features_core_and_site_bundle-2799531-6.patch, failed testing.

mpotter’s picture

Status: Needs work » Needs review
FileSize
8.15 KB

OK, let's try this patch.

Needed to adjust the Assignment plugin tests since the "core" package will actually be "test_mybundle_core" with this patch. Also fixed the other test that needed to prophetize the getFullname instead of getShortname.

  • mpotter committed 86ec485 on 8.x-3.x
    Issue #2799531 by mpotter: When in a bundle, check for bundle_core and...
mpotter’s picture

Status: Needs review » Fixed

Committed to 86ec485.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.