Right now the Core and Site assignment plugins will create new "core" and "site" packages to contain suggested config.
If there is already a bundle_core or bundle_site package exported within the current bundle namespace, it would be better to assign the core and site config to those modules as new items.
This would prevent the problem of selecting the "core" package, clicking Write and having it overwrite the existing bundle_core module. It also provides a nicer user experience where auto-detected items from the Core and Site assignment plugins show up as newly detected values.
To prevent problems with existing bundle_core and bundle_site modules that do not want this behavior, we should probably add the shortname to the config settings for Core and Site so other names can be used if desired.
Comment | File | Size | Author |
---|---|---|---|
#9 | features_core_and_site_bundle-2799531-9.patch | 8.15 KB | mpotter |
| |||
#6 | features_core_and_site_bundle-2799531-6.patch | 4.05 KB | mpotter |
#2 | features_core_and_site_bundle-2799531-2.patch | 4.05 KB | mpotter |
Comments
Comment #2
mpotter CreditAttribution: mpotter commentedHere is a patch to reassign Core and Site to the proper bundle_* existing packages. Probably going to break some tests?
Comment #4
mpotter CreditAttribution: mpotter commentedThink this is failing tests because #2796695: Features are duplicated after update isn't committed yet. Will resubmit after that is done.
Comment #5
mpotter CreditAttribution: mpotter at Phase2 commentedOK, other fixes have been committed, so let's run the tests on this patch again.
Comment #6
mpotter CreditAttribution: mpotter at Phase2 commentedHmm, re-queing the previous test didn't seem to work, so lets post a new patch identical to #2
Comment #9
mpotter CreditAttribution: mpotter at Phase2 commentedOK, let's try this patch.
Needed to adjust the Assignment plugin tests since the "core" package will actually be "test_mybundle_core" with this patch. Also fixed the other test that needed to prophetize the getFullname instead of getShortname.
Comment #11
mpotter CreditAttribution: mpotter at Phase2 commentedCommitted to 86ec485.