We currently have 1 submodule in head (core facets) but we'll be adding a new one in #2775963: FacetsSerializer views style plugin depends on optional rest module, we should move those into a modules subfolder.

CommentFileSizeAuthor
#3 move_submodules_into_a-2798483-3.patch6.17 KBNovitsh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Issue tags: +Novice

The core_search_facets and rest_facets modules should go into a folder modules. The patch should be only moving files.

git diff -M when creating a patch should make this easier to review.

Novitsh’s picture

Novitsh CreditAttribution: Novitsh as a volunteer and commented
FileSize
move_submodules_into_a-2798483-3.patch6.17 KB

Patch attached.
If you get errors from class ApcClassLoader, you'll need to clear the APC cache (webserver or php-fpm restart).

Novitsh’s picture

Novitsh CreditAttribution: Novitsh as a volunteer and commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

  • StryKaizer committed 51805e2 on 8.x-1.x authored by Novitsh 
    Issue #2798483 by Novitsh: Move submodules into a modules folder
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.