Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Porting age_checker to Drupal 8.
Maintaining the code on https://github.com/nitesh11/age_checker/tree/8.x-0.x.
Comment | File | Size | Author |
---|
Comments
Comment #2
Nitesh Sethia CreditAttribution: Nitesh Sethia as a volunteer and at QED42 commentedList of things which are done are:
Comment #3
nehajyoti CreditAttribution: nehajyoti as a volunteer commentedHi Nitesh,
Please review patch for age checker d8 functionality.
This does not include theming functionality of the module.
Comment #4
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedHi @nehajyoti
I have updated the status for your patch.
Comment #5
nehajyoti CreditAttribution: nehajyoti as a volunteer and commented@manav @nitesh
Here is the updated code of D8 version, including theme as well as functionalities https://github.com/nitesh11/age_checker/pull/2
Would also like to maintain this module further.
Please refer the CODE link for review : https://github.com/nehajyoti04/age_checker.
Comment #6
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedHi @nehajyoti
Sorry for late reply. I have reviewed you d8 module and found some issues. When i installed the module(from https://github.com/nehajyoti04/age_checker) it didn't ask me to setup configuration but its redirect me to http://example.com/age-gate this page. This module works only for anonymous user when they visited the site then this module ask for their date of birth etc and then proceed. According to D7 version without setting any configuration its should not work and also not work for authenticated user. Please check the logic and functionality.
Comment #7
navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commentedHi @manav Jyoti is working on it :-)
Comment #8
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedHi @navneet0693
I know Jyoti is working on it and sorry i forgotten to un-assign myself from the thread.
Comment #9
nehajyoti CreditAttribution: nehajyoti as a volunteer and commentedHi @manav,
I have fixed the issue : logged in users should not be redirected to age-gate page.
Though i am not displaying any error message to tell users to configure age checker settings page, as it is understood as per ReadMe file to fill up the configuraton.
Thanks for the review. Updated code is available on the same URL i.e https://github.com/nehajyoti04/age_checker
Le'me know if there are other major issues in the D8 version.
Comment #10
nehajyoti CreditAttribution: nehajyoti as a volunteer and commentedComment #13
hockey2112 CreditAttribution: hockey2112 commentedI installed the D8 version from https://github.com/nehajyoti04/age_checker. I then went to /admin/config/people/age-checker to configure the settings. I added messages, copyright, logo, button text. However, none of that text or the logo is showing up on the front-end. Am I missing a step?
Comment #14
Rangaswini CreditAttribution: Rangaswini at QED42 commentedComment #15
pratik_kambleI have tried the Drupal 8 version of the module. The porting of the module is not done completely. Changing the status to active.
Comment #16
pratik_kambleComment #17
MatthiasO CreditAttribution: MatthiasO as a volunteer commentedGot following error on 8.7.9
Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'element_validate_integer' not found or invalid function name in Drupal\Core\Form\FormValidator->doValidateForm() (line 282 of core/lib/Drupal/Core/Form/FormValidator.php).
Fixed it by removing element_validate_integer on the form elements (#element_validation) and changing to number types instead of textfield types (in SettingsForm.php and CountryConfig.php)
Based on https://www.drupal.org/node/1678914