Problem/Motivation

At the bottom of the entity display page, you can enable different view modes.
However the main usage of this page is to rearrange fields.
Currently, each entity display is saved, even when it's unchanged.

Proposed resolution

Remove the extra entity save calls.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Status: Active » Needs review
FileSize
858 bytes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Nice find!

I quickly checked for the types. \Drupal\field_ui\Form\EntityDisplayFormBase::submitForm constructs booleans, as config schema ensures that we save booleans, we are save here.

  • catch committed ce4e04f on 8.3.x
    Issue #2797967 by tim.plunkett: Field UI needlessly resaves each enabled...
catch’s picture

Version: 8.3.x-dev » 8.2.x-dev

Committed/pushed to 8.3.x, moving back to 8.2.x and leaving RTBC - this could go into a patch release.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2797967-field_ui-2.patch, failed testing.

catch’s picture

Status: Needs work » Reviewed & tested by the community
catch’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

Moving to 'to be ported' because it's currently impossible to distinguish between issues RTBC against 8.2.x that haven't been committed to any branch, vs. issues that have already been committed to 8.3.x and are waiting for 8.2.0 to land.

  • catch committed 28688d0 on 8.2.x
    Issue #2797967 by tim.plunkett: Field UI needlessly resaves each enabled...
catch’s picture

Status: Patch (to be ported) » Fixed

Committed/pushed to 8.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.