CommentFileSizeAuthor
#2 replace_t-2795779-2.patch21.74 KBShreya Shetty
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shreya Shetty created an issue. See original summary.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
Status: Active » Needs review
FileSize
replace_t-2795779-2.patch21.74 KB

Status: Needs review » Needs work

The last submitted patch, 2: replace_t-2795779-2.patch, failed testing.

Shreya Shetty’s picture

Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and at Trigyn Technologies Ltd commented
Status: Needs work » Needs review
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Needs review » Fixed

Not surprisingly, due to age, this was patch didn't apply. Partially applied and redid the remaining/skipped changes, thanks for the patch and bringing the issue to attention.

  • 070fe18 committed on 8.x-2.x 
    Issue #2795779 by Shreya Shetty, NickWilde: Replace t() with this->t()
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.