In IE 10 the dropdown widget (which is generated by JS) always shows the second option if the facet is inactive.

Current code in js/dropdown-widget.js first appends facet links, and then prepends the select element with the default empty option (default_option_label). Somehow this breaks dropdown in IE.
Other (modern) browsers have no such issues.

CommentFileSizeAuthor
#2 2795545-2.patch594 bytesLeksat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Leksat created an issue. See original summary.

Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Status: Active » Needs review
FileSize
2795545-2.patch594 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2795545-2.patch, failed testing.

Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Status: Needs work » Needs review

Test fail seems unrelated... Or am I wrong?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

That does look unrelated, sent for a retest.

Status: Needs review » Needs work

The last submitted patch, 2: 2795545-2.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

Those fails look unrelated, so we should probably have a look at what broke them.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs work » Reviewed & tested by the community

I don't see any reason why we shouldn't commit this, setting to RTBC

  • borisson_ committed 2d4715f on 8.x-1.x authored by Leksat 
    Issue #2795545 by Leksat: Dropdown widget is broken in Internet Explorer
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.