Sorry can't think of a neater title. If I now understand it correctly: if you have a 'yamlform' field reference on an entity to a form, you don't need to check the 'allow every entity to be the source entity box', because it should check to see if there is a referring field on the source entity.

However, it checks for the field by name 'yamlform', and not for a field of type 'yamlform', so any field added with the name field_xyz doesn't count.

Code is probably clearer, so patch to explain, follows in a second.

CommentFileSizeAuthor
#3 interdiff-2795307-1-3.txt2.32 KBjrockowitz
#3 yamlform_field-2795307-3.patch2.08 KBjrockowitz
#2 2795307-01.source_entity_has_yamlform_field.patch2.13 KBekes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ekes created an issue. See original summary.

ekes’s picture

ekes CreditAttribution: ekes as a volunteer commented
FileSize
2795307-01.source_entity_has_yamlform_field.patch2.13 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
Status: Active » Needs review
FileSize
yamlform_field-2795307-3.patch2.08 KB
interdiff-2795307-1-3.txt2.32 KB

Code makes sense but I made a few tweaks...

  • Changed protected to private
  • Renamed function and variables to be more specific
  • Removed negatives within if statement

Lets see if my patch passes

  • jrockowitz committed d3e01f1 on 8.x-1.x authored by ekes 
    Issue #2795307 by jrockowitz, ekes: Yamlform field referencing source...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz commented
Status: Needs review » Fixed

Please checkout 8.x-1.x or download the latest dev release to test.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.