Problem/Motivation

FetchManagerInterface::fetch does not document the possibility of exceptions. I think we should handle common http exceptions in FetchManager::fetch

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2795175-1.patch3.15 KBwebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2795175-1.patch3.15 KB
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented 
+++ b/src/EventSubscriber/ProxySubscriber.php
@@ -109,11 +107,12 @@ class ProxySubscriber implements EventSubscriberInterface {
-        throw new NotFoundHttpException();

I had to remove the NotFoundHttpException() to prevent recursion.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Status: Active » Reviewed & tested by the community

I've successfully applied this patch and it looks good to me. Therefore, RTBC'ed!

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Status: Reviewed & tested by the community » Active

I would change its status to "Active". I left a comment at #2464699: Use write & rename instead of write. Also check content length., but I would wait for the maintainers what they think about this issue.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
CreditAttribution: asrob at Integral Vision Ltd commented
Related issues: +#2464699: Use write & rename instead of write. Also check content length.

Add related issue.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Active » Needs work

Patch no longer applies cleanly.

  • axel.rutz committed d38f96f on 8.x-1.x 
    Issue #2795175 by webflo, axel.rutz: Handle guzzle client exceptions...
geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Clever Systems, MachbarMacher, DruConsult commented
Status: Needs work » Fixed

Rebased and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.