Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Line 341 in database.inc
Line 48 in unicode.inc
Line 111 in unicode.inc
Line 607 in aggregator.module
Line 763 in aggregator.module
Line 1110 in comment.module
Line 1027 in filter.module
Line 831 in node.module
Line 451 in openid.inc
Line 140 in update.fetch.inc
These are all areas that need to be updated to take advantage of the goodness of PHP5. More of a note to myself to remember that the patch needs to address all of these areas.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | php4_workarounds-3.patch | 4.6 KB | c960657 |
| #7 | php4_workarounds-2.patch | 10.2 KB | c960657 |
| #4 | php4_workarounds.patch | 8.08 KB | Susurrus |
| #2 | php4_workarounds.patch | 3.59 KB | Susurrus |
Comments
Comment #1
cburschkanode.module is fixed in this issue: #279382: Remove old PHP 4 workaround.
Comment #2
Susurrus CreditAttribution: Susurrus commentedLine 341 in database.inc
Line 48 in unicode.incLine 111 in unicode.inc
Line 607 in aggregator.module
Line 763 in aggregator.module
Line 1110 in comment.moduleLine 1027 in filter.module
Line 831 in node.moduleLine 451 in openid.incLine 140 in update.fetch.inc
Includes patch created in #279382: Remove old PHP 4 workaround.
Comment #3
catchThat check for outdate PCRE libraries - is it even necessary now?
Comment #4
Susurrus CreditAttribution: Susurrus commentedLine 341 in database.incLine 48 in unicode.incLine 607 in aggregator.moduleLine 763 in aggregator.moduleLine 1110 in comment.moduleLine 1027 in filter.moduleLine 831 in node.moduleLine 451 in openid.incAlso, I've noticed that the XML parsing in Drupal7 will need to be rewritten to take advantage of the new SimpleXML parser built into PHP5. Not sure if this should be a separate issue. So for the changes I've already made, they should be reviewed.
Comment #5
cburschkaI'd put XML parsing into a separate issue - one thing at a time. ;)
I'll review this in a bit.
Comment #6
lilou CreditAttribution: lilou commentedPatch partially failed on includes\database.inc (Index: 337, Size: 0 ) and includes\unicode.inc (Cannot apply hunk @@ 7 ).
Comment #7
c960657 CreditAttribution: c960657 commentedReroll.
The change to database.inc is no longer relevant.
I don't think so. According to the error message, the PCRE version bundled with PHP 4.3.3 is sufficient. That was PCRE 4.3. When compiling PHP 5.2 with an external PCRE library, PCRE 6.6 or newer is required. So it doesn't look like this is a problem anymore. The patch now removes the check.
Comment #8
Dries CreditAttribution: Dries commentedCommitted the patch in #7. Great patch. Thanks.
Comment #9
cburschkaIf you committed it, shouldn't this be fixed instead of CNW?
Comment #10
c960657 CreditAttribution: c960657 commentedActually, I noticed that the changes to includes/database.inc that were in the old patch from July are still relevant. The code has just moved to includes/database/database.inc. I should have grep'ed for "PHP 4" after rerolling the patch - sorry :-(
Also, I have removed the reference to PHP 4 in the comment for drupal_validate_utf8(). This is no longer relevant, and it is clearly documented in the PHP manual when the described behaviour was introduced, in case anybody is interested. While I was there, I updated the Doxygen comment to not talk about the implementation details but only the functions input/output, and instead put this inside the function (Drupal's manual show the function's source code, so the implementation specific details are not far away for those interested). Also the comment wasn't entirely correct - some 4 octet sequences are valid in UTF-8; and preg_match() also erroneously accepts 6 octet sequences, e.g.
"\xFD\x8D\x8D\x8D\x8D\x8D".There is still one PHP 4 reference left in unicode.inc, but that should probably be dealt with in a separate issue (as suggested in comment #5).
Comment #11
cburschkaWasn't db_rewrite_sql marked for extermination? I thought DBTNG had done away with it already...
Comment #12
drewish CreditAttribution: drewish commentedArancaytar, not yet see #299176: Replace db_rewrite_sql() with hook_query_alter().
Comment #13
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD! Thanks.