This is blocking

#2794767: Assert action is 'flag' or 'unflag'
#2584647: Flagging access system not extensible
#2792163: Removing Deprecated EntityInterface::urlInfo() from Flag code base
#2785387: Replaced deprecated SafeMarkup::checkPlain with Html::escape

CommentFileSizeAuthor
#3 status-2794781-3.patch1.55 KBmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107 created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I had the same problem in pathauto, fixed in #2765729: PathautoPattern->applies() exponentially slows down operations with large numbers of nodes, you just have to change the boolean "true" to a "'1'".

Unfortunate change, because it means that tests will now only pass with 8.3.x, but well, nothing we can do about that.

martin107’s picture

martin107 CreditAttribution: martin107 commented
Status: Active » Needs review
FileSize
status-2794781-3.patch1.55 KB

A little progress.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

That seems to be enough progress :)

  • socketwench committed 9f44fba on 8.x-4.x authored by martin107 
    Issue #2794781 by martin107: Fixed failing tests due to config schema...
socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Reviewed & tested by the community » Fixed

Odd how I still can't replicate this locally even on 8.3. Maybe my containers are still not cloning the right branch...

martin107’s picture

martin107 CreditAttribution: martin107 commented

@socketwench

environment things are tricky ....

I am using wodby for my container setup

https://github.com/Wodby/drupal-php

but just for the record here is my environment

I hope this helps....

php PHP 7.0.0

Lastest durpal 8.3.x
commit 24d528d802b66219064f4426c5d80255c17caeaf
Author: xjm
Date: Fri Sep 2 15:38:42 2016 -0500

Issue #2758559 by eporama, leolando.tan, kamalrajsahu21, tstoeckler, larowlan, claudiu.cristea: EntityType::setStorageClass() violates its interface

Flag 8.x-4.x

commit 4df85fbcc6d4a876940bb31a6ad55e577603a0e6
Author: asgorobets
Date: Sat Aug 27 14:30:36 2016 -0500

Issue #2599304 by asgorobets, socketwench: Fixed regression; reimplemented Contextual Link Display.

Steps to expose one failure.

cd core
../vendor/bin/phpunit -v --debug ../modules/flag/flag_bookmark/tests/src/Kernel/FlagBookmarkInstallUninstallTest.php

socketwench’s picture

socketwench CreditAttribution: socketwench commented

Huh. Mine is newer than that, but I still could not replicate the error.

martin107’s picture

martin107 CreditAttribution: martin107 commented

Ok so harmonizing descriptions of containers is as frustrating as

settings A's LAMP stack to works like B's MAMP stack ..... please excuse me while I go outside and shake my fist at the sky... I may be some time.

Ah that is better ...

This may or maynot be useful/relevant .... but my next thought.

Is schema validation performed by a third party project?

if so this additional description may be pertinent.

My method for updating composer is to use the composer_manager module 

php modules/composer_manager/scripts/init.php 
composer drupal-update

this is a controversial area - so I am not sure what the cool kids are doing these days.

I think I updated about 7 days ago...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.