In #2791163: Random automatic testing failures on SQLite with PHP 5.5 we struggled to use file_directory_os_temp() in the early test runner because the code is not autoloaded. Let's fix that.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
Issue tags: +Needs change record
FileSize
3.78 KB
alexpott’s picture

@catch suggested that we make the class more generic so we can stick over stuff here. Also rerolled because of #2794207: sys_get_temp_dir() can return a path with a trailing slash

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Works for me

  • catch committed b39b29a on 8.3.x
    Issue #2794249 by alexpott: Move file_directory_os_temp() to a class in...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x, thanks!

Fabianx’s picture

Version: 8.3.x-dev » 8.2.x-dev
Status: Fixed » Patch (to be ported)

I think this is okay for backport to 8.2.x (pending release manager exception), because this is a pure API addition with complete BC.

  • catch committed c74e3cf on 8.2.x
    Issue #2794249 by alexpott: Move file_directory_os_temp() to a class in...
catch’s picture

Status: Patch (to be ported) » Fixed

Cherry-picked to 8.2.x to fix the regression from #2791163: Random automatic testing failures on SQLite with PHP 5.5.

xjm’s picture

Title: Move file_directory_os_temp() to a class in Drupal\Component\FileSystem » [Needs change record] Move file_directory_os_temp() to a class in Drupal\Component\FileSystem
Status: Fixed » Needs work

@alexpott and @catch and I agreed to cherry-pick all three of these issue for the RC. We need a CR though.

alexpott’s picture

Title: [Needs change record] Move file_directory_os_temp() to a class in Drupal\Component\FileSystem » Move file_directory_os_temp() to a class in Drupal\Component\FileSystem
Status: Needs work » Fixed

Created and published a CR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.