[D7] Content Type Clone

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxdavidfiaty2745827git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Review of the 7.x-1.x branch (commit 7811160):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/content_type_clone.module
  --------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  --------------------------------------------------------------------------
   28 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but
      |       |     found 2 spaces
  --------------------------------------------------------------------------
  PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  --------------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. content_type_clone_create(): this will not scale if there are many nodes in a content type. The node_load_mulitple() will run into a timeout. Only load a limited number of nodes at once instead.
2. content_type_clone_copy_node(): why do you need to sleep() here? It only makes the process slower? Please explain the reason int he comment, what visibility? That the batch progresses slower?
3. "$context['message'] = t('Cloning node') . ' ' . $source_node->title;": never concatenate variables to translatable strings, use placeholders with t() instead. See https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/t/7.x . Not sure if this message is later displayed as is in HTML - this could also be an XSS vulnerability. This should be fixed in any case and is currently an application blocker, you need to understand how to use t() correctly. Please check all your t() calls with variables.
4. content_type_clone_create_form(): doc block is wrong, this is not hook_form(). See https://www.drupal.org/docs/develop/coding-standards/api-documentation-a... . Same for content_type_clone_create_form_validate().
5. Your module file is quite long. Can you split up the page and form callbacks into a dedicated *.admin.inc file?
6. content_type_clone_create_form_submit(): Why do you define $function here? Just call the function directly?
7. content_type_clone_preprocess_html(): don't add your CSS in a global HTML preprocess hook, add it with #attached on the render array of you page/form callback. See https://api.drupal.org/api/drupal/developer%21topics%21forms_api_referen...

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Review of the 7.x-1.x branch:

I found only 1 performance issue:
In content_type_clone_preprocess_html, you are calling the arg-funtion three times. Maybe it's better to use:

$args = arg();
if ($args[0] == 'admin' && $args[2] == 'clone' && $args[3] == 'create') {
...
}

This way, you're calling one time the arg-function instead of three times. Just a small thing to think of.

You also added the CSS via attached to in content_type_clone_create_form(), but didn't delete the preprocess_html function.

Beside above, this module looks good to me!

I tested this module, a great module, works very well ...

:-)

Hi David,

I am trying to cloning content type but getting some error. Please refer below image.

Module is working fine form me.

Suggestion
1. Once cloning is complete page should be redirect to content type list page.

Hi,

I used your module and found it really great as it saves time.

But when I cloned my content type(Eg: gallery) then only the body gets cloned in manage fields as well as in manage display. My all the custom fields didn't get clone.

Thus look into this.

Hi David,

you can just install fresh drupal and install this module and take any (basic or article) content type clone. issue will be reproduce.
Try it

Hi David,

As per Sumit(#22) you reproduce the issue...

I just checked my logs and there was a warning coming from your module:

"Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'content_type_clone_set_target_field' not found or invalid function name in _batch_process() (line 284 of /var/www/html/drupald/drupal/includes/batch.inc)."

You can try on any of the content types whether it's custom or not.

Working fine now. Great work...

HI David,

Below is my manual review :
1. use l() function on line 'No content types available. Add content type.',

Hi David,

Now its working.

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.

Hi David Fiaty,

As per Kiamlaluno, it is approved and now you can promote your sandbox project to Full Project as globally.