https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Entity!EntityInte...

CommentFileSizeAuthor
#5 hairshirt-2792163-5.patch1.42 KBmartin107
#2 2792163-2.patch617 bytesPradnya Pingat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pradnya Pingat created an issue. See original summary.

Pradnya Pingat’s picture

Pradnya Pingat CreditAttribution: Pradnya Pingat at Blisstering Solutions commented
Assigned: Pradnya Pingat » Unassigned
Status: Active » Needs review
FileSize
2792163-2.patch617 bytes

Please find the patch attached.

martin107’s picture

martin107 CreditAttribution: martin107 commented
Component: Documentation » Flag core
Status: Needs review » Reviewed & tested by the community

I agree,

it deprecated, patch looks clean so +1 from me.

Other reviews take the line that these deprecation issues are low priority.

I have been caught out too many times and had to fix these issue like these in a mad panic on a deadline.
I would much rather de-stress the situation and fix them up early in small digestible pieces as we see them.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -drupal8

Looks good, but any chance we could also do the calls to this in flag.module?

martin107’s picture

martin107 CreditAttribution: martin107 commented
Status: Needs work » Needs review
FileSize
hairshirt-2792163-5.patch1.42 KB

My bad - I missed that ...done.

Status: Needs review » Needs work

The last submitted patch, 5: hairshirt-2792163-5.patch, failed testing.

The last submitted patch, 5: hairshirt-2792163-5.patch, failed testing.

socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Needs work » Fixed

Fixed now that branch errors are resolved.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.