The convertUrlToAbsolute() function doesn't properly detect when the urls are protocol relative (ie. starts with //) and instead thinks that they are relative urls instead. This leads to corrupted urls in the meta tags.

Attached is a patch.

CommentFileSizeAuthor
#4 metatag-n2791963-4.patch2.4 KBDamienMcKenna
metatag-protocol-relative.patch618 bytesttkaminski
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ttkaminski created an issue. See original summary.

ttkaminski’s picture

ttkaminski CreditAttribution: ttkaminski commented
Status: Active » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Need some tests to confirm the behavior.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
Parent issue: » #2758749: Plan for Metatag 7.x-1.18 release
FileSize
metatag-n2791963-4.patch2.4 KB

Minor tidying of the code, plus updated the comment. And a test.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Issue tags: -Needs tests

Similar bug in D8 now: #2840751: Protocol-relative URLs are broken.