API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Cache%21C...

I was looking at drupal_flush_all_caches() and noticed that Cache::getBins declares its return type is array but the more accurate data type indicator \Drupal\Core\Cache\CacheBackendInterface[] is preferable.

CommentFileSizeAuthor
cache_data_type.patch511 bytescilefen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cilefen created an issue. See original summary.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly. Reviewed API documentation and this makes sense to me.

  • catch committed 61699f0 on 8.3.x 
    Issue #2791211 by cilefen: Cache::getBins should explain the returned...

  • catch committed 2757806 on 8.2.x 
    Issue #2791211 by cilefen: Cache::getBins should explain the returned...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.