Note: For guidelines and instructions pages linked below, log in with user name / password: drupal/drupal.

Task for this issue

Copy edit the following topic:

Title: Updating a Module
Section: Security and Maintenance
File name: security-update-module.txt

Look for:
- Typographical errors
- Spelling errors
- Grammar and usage errors
- Punctuation problems
- Adherence to the project's editing guidelines: https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines-edi... (access: drupal / drupal )
- Adherence to the project's writing guidelines: https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines-wri... (access: drupal / drupal )
- Formatting problems in the output. The User guide output can be found on: https://userguide_new-drupal.dev.devdrupal.org/d8guide/en/index.html (access: drupal / drupal )
- Also note (but do not fix) problems with screen shots in the output. [Making new screenshots is out of scope for this issue. Checking the "alt" text for screenshots is within the scope of this issue, however. So is fixing or at least noting formatting problems with images, such as images that are too expanded, or (conversely) are going out of the page area. See also: https://userguide_new-drupal.dev.devdrupal.org/guidelines/formatting.htm... ]

Note that the "single-issue" guidelines in the Editing guidelines page, as well as the entire Writing guidelines page, should have already been enforced. But it is still a good idea to at least check them quickly.

Instructions

See https://userguide_new-drupal.dev.devdrupal.org/guidelines/instructions.h... -- but skip the section on finding a task to do, since you have selected this one.

Checklist for this task

- Is a patch file provided? If only one or a few topics were edited, you can instead attach the updated source file(s).
- Is the edit complete and correct?
- Is the work free from additional edits outside the scope of the provided guidelines or task?
- Is attribution provided? See https://userguide_new-drupal.dev.devdrupal.org/guidelines/guidelines.htm...

CommentFileSizeAuthor
#5 user_guide-security-update-module-2790887-5.patch4.62 KBjojyja
#3 security_update_module-2790887_3.patch4.54 KBjojyja
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon created an issue. See original summary.

jojyja’s picture

jojyja CreditAttribution: jojyja at Red Crackle commented
Assigned: Unassigned » jojyja

I'm taking this up!

jojyja’s picture

jojyja CreditAttribution: jojyja at Red Crackle commented
Status: Active » Needs review
FileSize
security_update_module-2790887_3.patch4.54 KB

Here is the updated patch!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Thanks! Mostly excellent. Two small things to address:

  1. +++ b/source/en/security-update-module.txt
@@ -39,16 +39,15 @@ modules.
 page to your local computer. Unzip the file and look for _README.txt_,
-_INSTALL.txt_ and _UPGRADE.txt_ that come with the module's installation
-file. Also review the release notes by clicking the version number of the
-download on the project page for the version you're downloading.
+_INSTALL.txt_, and _UPGRADE.txt_ that come with the module's installation
+file. Also, review the release notes by clicking the version number you're downloading.

    In this edit, we lost the information on where to go to click this version number (which is on the project page for the module). 

  2. +++ b/source/en/security-update-module.txt
@@ -127,6 +126,4 @@ https://www.drupal.org/node/250790[_Drupal.org_ community documentation page "Up
-https://www.drupal.org/node/250790["Updating modules"],
-copyright 2000-2016 by the individual contributors to the
-https://www.drupal.org/documentation[Drupal Community Documentation].
+https://www.drupal.org/node/250790["Updating modules"].

    Actually, we need to keep this copyright attribution information, which refers to the source page that this was adapted from.

jojyja’s picture

jojyja CreditAttribution: jojyja at Red Crackle commented
Status: Needs work » Needs review
FileSize
user_guide-security-update-module-2790887-5.patch4.62 KB

Thanks for the feedback. Here is the updated patch.

  • jhodgdon committed afec519 on 8.x-0.x authored by jojyja 
    Issue #2790887 by jojyja: Copy edit security-update-module.txt
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Fixed

Looks good, thanks!

  • jhodgdon committed afec519 on 8.x-2.x authored by jojyja 
    Issue #2790887 by jojyja: Copy edit security-update-module.txt

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.