As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

Also correct other coding standards issues and follow Drupal best practices as per the latest (dev) version of Coder.

Pareview review : http://pareview.sh/pareview/httpgitdrupalorgprojectalexagit-8x-1x

CommentFileSizeAuthor
#20 make_code_compliant-2789983-20.patch4.83 KBhampercm
#18 make_code_compliant-2789983-18.patch1.74 KBshruti1803
#16 interdiff-2789983-13-16.txt4.68 KBshruti1803
#16 coding_standard-2789983-16.patch1.74 KBshruti1803
#13 make_code_compliant-2789983-13.patch5.35 KBhampercm
#8 make_code_compliant-2789983-8.patch11.05 KBhampercm
#6 make_code_compliant-2789983-6.patch8.2 KBhampercm
#4 make_code_compliant-2789983-4.patch8.15 KBhampercm
removed-file-docblock-alexa.patch2.19 KBaks22
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aks22 created an issue. See original summary.

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Component: Documentation » Code
Assigned: aks22 » Unassigned
Category: Bug report » Task
Status: Needs review » Needs work
Issue tags: -Documentation

Your patch no longer applies. Can you re-roll please?

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Title: Remove @file tag docblock from all the .php files. » Make code compliant with Drupal coding standards
Assigned: Unassigned » hampercm
Issue summary: View changes
Status: Needs work » Active
hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
FileSize
make_code_compliant-2789983-4.patch8.15 KB

This patch makes the module fully compliant with current Drupal coding standards.

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Assigned: hampercm » Unassigned
Status: Active » Needs review

This patch makes the module fully compliant with current Drupal coding standards.

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
FileSize
make_code_compliant-2789983-6.patch8.2 KB

Avoid using "Drupal" in class names declared in contributed modules.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Issue summary: View changes

Added pareview review link http://pareview.sh/pareview/httpgitdrupalorgprojectalexagit-8x-1x

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
FileSize
make_code_compliant-2789983-8.patch11.05 KB

Follow Drupal best practices, add missing README files.

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Title: Make code compliant with Drupal coding standards » Make code compliant with Drupal coding standards and best practices

  • hampercm committed 2796c3c on 8.x-1.x 
    Issue #2789983 by hampercm, aks22: Make code compliant with Drupal...
hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Status: Needs review » Fixed
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Fixed » Active

Still needs more love http://pareview.sh/pareview/httpgitdrupalorgprojectalexagit-8x-1x

hampercm’s picture

hampercm CreditAttribution: hampercm as a volunteer and at Acquia commented
Issue summary: View changes
FileSize
make_code_compliant-2789983-13.patch5.35 KB

This patch fixes the remaining issues to match standards from the latest dev version of the Coder module (I had been using the latest official release of that module, which resulted in some newer standards changes being missed).

Note there is one line in a README that can't be wrapped at 80 characters, as it contains a long URL.

hampercm’s picture

hampercm CreditAttribution: hampercm as a volunteer and at Acquia commented
Status: Active » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Needs review » Needs work

Use phpcbf to fix the stuff for you. hpcbf --standard=Drupal alexa/

  1. +++ b/README.md
@@ -1,5 +1,5 @@
+handler module (see the included alexa_demo module for an example) to handle ¶

    Extra spaces at line. 

  2. +++ b/alexa_demo/README.md
@@ -2,6 +2,8 @@ This is an example module implementing a request subscriber for Amazon Echo
+>For any other intent routed to this module the module will just respond ¶

    Extra spaces at line.

shruti1803’s picture

shruti1803 CreditAttribution: shruti1803 at Iksula commented
Status: Needs work » Needs review
FileSize
coding_standard-2789983-16.patch1.74 KB
interdiff-2789983-13-16.txt4.68 KB
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented

@shruti1803
Could you update hte patch with right name ? here the interdiff is the patch

shruti1803’s picture

shruti1803 CreditAttribution: shruti1803 at Iksula commented
FileSize
make_code_compliant-2789983-18.patch1.74 KB

updated patch name.

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Status: Needs review » Needs work

The patch in #18/#16 seems incomplete, as indicated by the interdiff being so large.

hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Status: Needs work » Needs review
FileSize
make_code_compliant-2789983-20.patch4.83 KB

Removed the two extra spaces

  • hampercm committed 60077b7 on 8.x-1.x 
    Issue #2789983 by hampercm, shruti1803, aks22: Make code compliant with...
hampercm’s picture

hampercm CreditAttribution: hampercm at Acquia commented
Status: Needs review » Fixed
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented

Nice Chris!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.