Problem/Motivation
Reviewing #2687941: [Policy, no patch] Within the Function Calls section, delete explicit mention of padding spacing in a block of related assignments I noticed the indention for the colors was not aligned. Additionally while the // Used as rotate background colors
comment was relevant to the patch it came in with, those colors are just colors available to the testing class and could be used for anything in additional tests. The comment just duplicates what's actually implemented.
Proposed resolution
Fix it indentation and remove confusing comment.
Remaining tasks
#2687941: [Policy, no patch] Within the Function Calls section, delete explicit mention of padding spacing in a block of related assignments may block or invalidate this?
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#2 | fix_gd_test_indention.patch | 1.37 KB | neclimdul |
Comments
Comment #2
neclimdulPatch implementing fixes.
Comment #3
Chi CreditAttribution: Chi commentedA trivial fix.
Comment #4
catchThere's now #2816445: Forbid using more than one space around operators open. Given one of the arguments in both issues was reducing unnecessary diffs, let's postpone it on that discussion so we don't have to change it twice potentially.
Comment #18
quietone CreditAttribution: quietone at PreviousNext commentedThanks. This was fixed in #3239935: Refactor ToolkitGdTest