[D8] Simple Ad Module

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxshafiqhossain2784733git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

The download link provided doesn't work. Is this an official project yet or is it still in Sandbox. I need it in order to move a Drupal 6 project to Drupal 8, otherwise I guess I"ll have to move it to Drupal 7 for the meantime (sure don't want to migrate twice).

Upon Installation and then clicking any of links under tools (for instance, /admin/adplus/active), hits an error :

Recoverable fatal error: Argument 5 passed to Drupal\adplus\Controller\AdPlusReportController::__construct() must be an instance of Drupal\adplus\Controller\EntityManagerInterface, instance of Drupal\Core\Entity\EntityManager given, called in /var/www/html/drupal-8.2.4/modules/contrib/adplus/src/Controller/AdPlusReportController.php on line 83 and defined in Drupal\adplus\Controller\AdPlusReportController->__construct() (line 68 of /var/www/html/drupal-8.2.4/modules/contrib/adplus/src/Controller/AdPlusReportController.php)

Also, I found there are two taxonomies created, viz Front and Inner, however, upon using one of those taxonomies e.g. 'Front' for ad locations, I assumed, I would be able to see the ad on front page ? But for some reason, it didn't. Not sure about it. Would be great if you could provide hook_help() to guide how to use the module rather than guessing it throughout.

Please have a fix to it.
Thanks

Few more updates needs/suggested to be fixed :

1. Tables created in hook_schema() should be dropped off in hook_uninstall()
2. Upon module un-installations, delete the contents created for the content type.

Thanks

I run a pareview.sh automatic test on this: https://git.drupal.org/sandbox/shafiqhossain/2784733.git
and found many (many) errors in many code files. Here is the review: https://pareview.sh/node/547

I guess you should fix them, isn't it?

Getting WSOD while installing the module.

A WSOD means you have not configured your PHP development setup correctly. See https://www.drupal.org/node/158043 and post the error message you get here.

I have tried the module on vanila instance drupal 8.2.5 and getting this error

"Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "router.route_provider.old". Did you mean one of these: "router.route_provider", "router.route_preloader"? in Drupal\Component\DependencyInjection\Container->get() (line 157 of /var/www/html/drupal-8.2.5/core/lib/Drupal/Component/DependencyInjection/Container.php)."

Its a core issue or module issue I'm unable to test. @klausi Do I need to test the module with the patch available in https://www.drupal.org/node/2788087.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.