Missing configuration schema for current_theme condition plugin

@Chi that would suggest that this functionality is not tested since if anything is saved to configuration with no schema during core testing an error is produced.

For what it's worth, I confirm the bug and give a thumb up on the #8 patch. Would be nice to have it committed.

The patch in #8 doesn't test the actual plugin. I think we need an integration test to test the plugin. I'm pretty sure that's what @alexpott wanted in #3.

#8 still applies cleanly on 9.3.x so removing "Needs Reroll" issue tag & initiated testing against 9.3.x
Keeping it in NW for tests.

Added missing test.

The IS is empty so that will need to be added I believe.

Test fails for the #29 with following debug info

The website encountered an unexpected error. Please try again later.

Error: Call to a member function buildConfigurationForm() on null in Drupal\condition_test\FormController->buildForm() (line 53 of core/modules/system/tests/modules/condition_test/src/FormController.php).
call_user_func_array(Array, Array) (Line: 534)
Drupal\Core\Form\FormBuilder->retrieveForm('condition_node_type_test_form', Object) (Line: 281)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)

@Ankit.Gupta your patch is removing a file from #25 I believe.

Also @Ankit.Gupta please upload an interdiff so that we can see the changes please.

Needs reroll from #25 please

Thank you @rpayanm I see all the original files from #25 are in the MR

There a build error

Commit check failures
The last patch or MR doesn't pass commit checks, could you make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel...

Sorry, get it.

No sorry needed. Will wait to see if it turns green and review.

Looks good.

There's no failing test only patch here, so I ran it locally to confirm it fails correctly

Here's the output

Testing Drupal\Tests\system\Functional\Condition\ConditionFormTest
E                                                                   1 / 1 (100%)R

Time: 00:01.484, Memory: 10.00 MB

There was 1 error:

1) Drupal\Tests\system\Functional\Condition\ConditionFormTest::testConfigForm
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for condition_test.settings with the following errors: condition_test.settings:visibility.current_theme missing schema

/data/app/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:94
/data/app/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
/data/app/core/lib/Drupal/Core/Config/Config.php:229
/data/app/core/lib/Drupal/Core/Config/ConfigInstaller.php:395
/data/app/core/lib/Drupal/Core/Config/ConfigInstaller.php:148
/data/app/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/data/app/core/lib/Drupal/Core/Extension/ModuleInstaller.php:319
/data/app/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/data/app/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:474
/data/app/core/tests/Drupal/Tests/BrowserTestBase.php:543
/data/app/core/tests/Drupal/Tests/BrowserTestBase.php:362

So yep, it does ✅

Committed to 10.1.x, doesn't apply to 10.0.x - so flagging for reroll.

We can't commit this to 9.4.x as it would require an empty post update hook to clear the schema cache. We have other update hooks in 9.5/10.0/10.1 that would handle this for us.

So can we get a 10.0.x and a 9.5.x version - we have a week to get them in without needing another update hook.

A simple reroll.

@Rajeshreeputra, creating an MR on 10.1.x not needed here. The fix has already been applied to that branch. Help save our resources by reading the issue before submitting an MR for testing. Wait, why is the MR merge-able? Oh, I see that it is duplicating code. We prefer that you find ways to contribute that help the Drupal project. Therefor, credit has been removed per How is credit granted for Drupal core issues.

- Patch #43 applies to both 10.0.x and 9.5.x.
- Testbot comes back green on both branches.

RTB for me.

Committed/pushed to 10.0.x and cherry-picked to 9.5.x, thanks!