Bad nid column in comment_notify_unsubscribe_by_hash() and the logic needs work since an anonymous commenter would unsubscribe all anonymous commenters.

CommentFileSizeAuthor
#7 2786985-7.patch2.83 KBgnuget
#7 2786985-7-only-test.patch972 bytesgnuget
#4 2786985-4.patch1.88 KBchegor
#2 comment_notify-2786985-unsubscribe.patch2.03 KBjohn.money
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

john.money created an issue. See original summary.

john.money’s picture

john.money CreditAttribution: john.money at Acquia commented
FileSize
comment_notify-2786985-unsubscribe.patch2.03 KB

Status: Needs review » Needs work

The last submitted patch, 2: comment_notify-2786985-unsubscribe.patch, failed testing.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented
Status: Needs work » Needs review
FileSize
2786985-4.patch1.88 KB

Updated patch.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

Thanks for your help fixing this bug! The changes look right to me and also simplify the code - the best solution :)

Any chance you can provide an automated test to cover this case so we know it keeps working in the future?

john.money’s picture

john.money CreditAttribution: john.money at Acquia commented

Hi greggles... will circle back around in a few weeks when I have some free time for the tests.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
FileSize
2786985-7-only-test.patch972 bytes
2786985-7.patch2.83 KB

Here the test.

I hope this helps to move forward this issue.

Thanks.

The last submitted patch, 7: 2786985-7-only-test.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Needs review » Fixed

Thanks for the work on this, everyone, and for the tests, gnuget!

Now committed/pushed.

  • greggles committed 9f6d1b4 on 8.x-1.x authored by gnuget 
    Issue #2786985 by gnuget, john.money, chegor: Unsubscribe from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.