Deprecated functions are used for link and entity type.

CommentFileSizeAuthor
#11 deprecated_functions-2786873-11.patch16.52 KBborisson_
#11 interdiff.txt12.97 KBborisson_
#9 deprecated_functions-2786873-9.patch8.25 KBborisson_
#9 interdiff.txt3.16 KBborisson_
#6 patch-2786873.patch4.52 KBchaitanya17
#4 patch-2786873.patch4.53 KBchaitanya17
#2 patch-2786873.patch4.51 KBchaitanya17
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chaitanya17 created an issue. See original summary.

chaitanya17’s picture

chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
Status: Active » Needs review
FileSize
patch-2786873.patch4.51 KB

I have created patch for replacing deprecated functions.

Please check attachment.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Needs work 
+++ b/src/Plugin/DsLayout.php
@@ -164,7 +165,7 @@
+        $form['ds_classes']['info'] = array('#markup' => Link::fromTextAndUrl(t('Manage region and field CSS classes'), $url)->toString());

@@ -172,7 +173,7 @@
+        $form['ds_classes']['info'] = array('#markup' => '<p>' . $this->t('You have not defined any CSS classes which can be used on regions.') . '</p><p>' . Link::fromTextAndUrl(t('Manage region and field CSS classes'), $url)->toString() . '</p>');

Let's switch the t( call here into $this-t( if the StringTranslationTrait is available here, if it isn't, it might be a good idea to include it anway.

chaitanya17’s picture

chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
Status: Needs work » Needs review
FileSize
patch-2786873.patch4.53 KB

Hi borisson_

I have done the needful. Thanks for comment.
Please check attached patch.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Next time please provide an interdiff as well: https://www.drupal.org/documentation/git/interdiff

I have reviewed the patch again and the changes look good, RTBC.

chaitanya17’s picture

chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented
FileSize
patch-2786873.patch4.52 KB

Hi borisson_,

Please refer latest Patch. DsLayout Class specific replacement.

Regards
Chaitanya17

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Version: 8.x-1.x-dev » 8.x-3.x-dev
Status: Reviewed & tested by the community » Needs review

Checking for 8.x-3.x

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Category: Bug report » Task
Status: Needs review » Needs work

Please combine with #2858575: Replace some deprecated functions.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs work » Needs review
FileSize
interdiff.txt3.16 KB
deprecated_functions-2786873-9.patch8.25 KB

Not everything in the other issue still applied, What I copied from the old issue is shown here in interdiff.txt.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

We should inject all the services. Otherwhise, looking good.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs work » Needs review
FileSize
interdiff.txt12.97 KB
deprecated_functions-2786873-11.patch16.52 KB

I hope this resolves your issues Bram.

  • aspilicious committed 8e1b381 on 8.x-3.x authored by borisson_ 
    Issue #2786873 by chaitanya17, borisson_: Deprecated functions are used...
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Fixed

NICE! Thank you guys!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.