Problem/Motivation

This is a split from #2702227: Image styles for private files are serving the original instead of derivative.

In \Drupal\image\Controller\ImageStyleDownloadController we are preparing a lock name that uses some cryptography even we don'y use it.

Proposed resolution

Fix it.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2786855-2.patch974 bytesclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Status: Active » Needs review
FileSize
2786855-2.patch974 bytes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Title: Don't compute the lock name if not necessary, when generating image derivatives » Don't compute the lock name if not necessary when generating image derivatives
zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
Status: Needs review » Reviewed & tested by the community

Quick & clean fix. All that has to be done in just two lines. Looks good to me!

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +Performance
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.3.x and cherry-picked to 8.2.x, thanks!

  • catch committed d798c28 on 8.3.x 
    Issue #2786855 by claudiu.cristea: Don't compute the lock name if not...

  • catch committed 2c9342c on 8.2.x 
    Issue #2786855 by claudiu.cristea: Don't compute the lock name if not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.